gh-132467: Add test case to check whether GenericAlias instance is not class, update docstring of `typing._GenericAlias` by AbduazizZiyodov · Pull Request #133504 · python/cpython

AbduazizZiyodov · 2025-05-06T10:16:01Z

Description

As discussed in the issue, we can't change behaviour of inspect.isclass for GenericAlias instances, so that we need to document that they are not considered to be a class.

Summary

Added one test case
Updated docstring of typing._GenericAlias. Added one note, changed format of docstring a bit
Online docs was also updated

* edit: I should not have updated typing docs, doc was for typing spec only, not about runtime behaviour. So I updated stdtypes docs.

Issue: Document that inspect.isclass returns False for GenericAlias instances #132467

…d to be class, update docstring of typing._GenericAlias

bedevere-app · 2025-05-06T10:16:07Z

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

bedevere-app · 2025-05-06T13:23:08Z

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

…es at runtime

bedevere-app · 2025-05-06T17:02:56Z

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

bedevere-app · 2025-05-06T17:36:11Z

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>

bedevere-app · 2025-05-07T04:15:31Z

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

AbduazizZiyodov · 2025-07-21T23:08:08Z

Hi @JelleZijlstra, I(we)'ve addressed requested changes, just checking in if there is anything needed from my side? Thanks.

github-actions · 2026-04-24T06:38:23Z

This PR is stale because it has been open for 30 days with no activity.

bedevere-app · 2026-06-03T13:05:20Z

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>

bedevere-app · 2026-06-03T13:07:02Z

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>

bedevere-app · 2026-06-03T13:07:19Z

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

read-the-docs-community · 2026-06-03T13:11:53Z

Documentation build overview

📚 cpython-previews | 🛠️ Build #32972747 | 📁 Comparing 9a22782 against main (6453065)

🔍 Preview build

1 file changed

± library/stdtypes.html

miss-islington-app · 2026-06-03T13:35:31Z

Thanks @AbduazizZiyodov for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖

miss-islington-app · 2026-06-03T13:35:42Z

Sorry, @AbduazizZiyodov and @JelleZijlstra, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 5915a1fb9d8499387e371c6801b40c55cf126dbf 3.14

bedevere-app · 2026-06-03T13:35:47Z

GH-150854 is a backport of this pull request to the 3.15 branch.

miss-islington-app · 2026-06-03T13:35:48Z

Sorry, @AbduazizZiyodov and @JelleZijlstra, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 5915a1fb9d8499387e371c6801b40c55cf126dbf 3.13

JelleZijlstra · 2026-06-03T15:26:19Z

@AbduazizZiyodov thanks for contributing! Do you want to see if you can get the backports to 3.13 and 3.14 up?

…ses (GH-133504) (#150854) gh-132467: Document and test that generic aliases are not classes (GH-133504) (cherry picked from commit 5915a1f) Co-authored-by: Abduaziz π <mail@ziyodov.uz> Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>

Add test case to check whether GenericAlias objects are not considere…

0e5d196

…d to be class, update docstring of typing._GenericAlias

AbduazizZiyodov requested review from AlexWaygood and JelleZijlstra as code owners May 6, 2025 10:16

bedevere-app Bot mentioned this pull request May 6, 2025

Document that inspect.isclass returns False for GenericAlias instances #132467

Open

bedevere-app Bot added the awaiting review label May 6, 2025

Merge branch 'main' into genericalias-isclass-test

8325906

Update online docs, explain that GenericAlias instances are not class…

fbaaa4e

…es at runtime

Add tests against standard generic classes, rename test case

817a313

JelleZijlstra reviewed May 6, 2025

View reviewed changes

Comment thread Doc/library/stdtypes.rst Outdated

Update Doc/library/stdtypes.rst

ee0ed36

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>

AbduazizZiyodov requested a review from JelleZijlstra May 7, 2025 07:23

github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 24, 2026

JelleZijlstra reviewed Jun 3, 2026

View reviewed changes

Comment thread Doc/library/stdtypes.rst Outdated

Comment thread Lib/typing.py Outdated

Merge branch 'main' into genericalias-isclass-test

9bfd2cc

Update Doc/library/stdtypes.rst

c36532f

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>

Update Lib/typing.py

9a22782

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>

JelleZijlstra added skip news needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Jun 3, 2026

JelleZijlstra enabled auto-merge (squash) June 3, 2026 13:10

JelleZijlstra merged commit 5915a1f into python:main Jun 3, 2026
60 checks passed

bedevere-app Bot removed the awaiting review label Jun 3, 2026

miss-islington-app Bot assigned JelleZijlstra Jun 3, 2026

bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jun 3, 2026

AbduazizZiyodov deleted the genericalias-isclass-test branch June 3, 2026 13:36

Uh oh!

Conversation

AbduazizZiyodov commented May 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Summary

Uh oh!

bedevere-app Bot commented May 6, 2025

Uh oh!

bedevere-app Bot commented May 6, 2025

Uh oh!

bedevere-app Bot commented May 6, 2025

Uh oh!

bedevere-app Bot commented May 6, 2025

Uh oh!

Uh oh!

bedevere-app Bot commented May 7, 2025

Uh oh!

AbduazizZiyodov commented Jul 21, 2025

Uh oh!

github-actions Bot commented Apr 24, 2026

Uh oh!

Uh oh!

Uh oh!

bedevere-app Bot commented Jun 3, 2026

Uh oh!

bedevere-app Bot commented Jun 3, 2026

Uh oh!

bedevere-app Bot commented Jun 3, 2026

Uh oh!

read-the-docs-community Bot commented Jun 3, 2026

Documentation build overview

Uh oh!

Uh oh!

miss-islington-app Bot commented Jun 3, 2026

Uh oh!

miss-islington-app Bot commented Jun 3, 2026

Uh oh!

bedevere-app Bot commented Jun 3, 2026

Uh oh!

miss-islington-app Bot commented Jun 3, 2026

Uh oh!

JelleZijlstra commented Jun 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

AbduazizZiyodov commented May 6, 2025 •

edited

Loading