-
-
Notifications
You must be signed in to change notification settings - Fork 33.9k
Add Emscripten test skips for recently added tests. #143551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
!buildbot emscripten |
|
🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 1118f6f 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F143551%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
|
!buildbot emscripten |
|
🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 9c4d800 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F143551%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
vstinner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I didn't test the change, I just read the code changes.
hoodmane
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @freakboy3742 !
Some minor changes to some tests that recently started failing on Emscripten:
A tweak to how free-threading is detected in the profiler tests, matching other usages (because an environment variable value ofNot sure what is going on with this one, but it caused all the Windows and Ubuntu tests to fail.Py_GIL_DISABLED=0shouldn't be interpreted as "GIL disabled")