gh-143535: Document dispatch behavior of singledispatchmethod #143592
Conversation
|
All commit authors signed the Contributor License Agreement. |
Doc/library/functools.rst
Outdated
| @neg.register | ||
| def _(self, arg: bool): | ||
| return not arg | ||
| .. note:: |
There was a problem hiding this comment.
- Don't use a note.
- Put the paragraph after we mention the behavior of classmethod/staticmethod
- Don't write
x.f(a) != C.f(x,a)it's confusing and ca be wrong.
There was a problem hiding this comment.
Thanks for the clarification, I will remove the note and describe the behaviour in paragraph format, in text. I will update the PR shortly.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I have made the requested changes; please review again. |
|
Thanks for making the requested changes! @picnixz: please review the changes made to this pull request. |
2 participants
The PR clarifies the behavior of
singledispatchmethodin the documentation. It always dispatches the first argument during call, regardless of whether the method is bound or unbound, as a resultxf(a)!=c.f(x,a). The behavior is intentional and required to support correct dispatch forstaticmethodandclassmethod.singledispatchmethoddispatches on theselfargument when invoked from class level #143535📚 Documentation preview 📚: https://cpython-previews--143592.org.readthedocs.build/