Disable pip version check when upgrading certifi#144632
Merged
ned-deily merged 1 commit intopython:mainfrom Feb 10, 2026
Merged
Disable pip version check when upgrading certifi#144632ned-deily merged 1 commit intopython:mainfrom
ned-deily merged 1 commit intopython:mainfrom
Conversation
ned-deily
approved these changes
Feb 10, 2026
|
Thanks @hugovk for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
|
Thanks @hugovk for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 10, 2026
(cherry picked from commit 80ba4e1) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 10, 2026
(cherry picked from commit 80ba4e1) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
|
GH-144640 is a backport of this pull request to the 3.13 branch. |
|
GH-144641 is a backport of this pull request to the 3.14 branch. |
ned-deily
pushed a commit
that referenced
this pull request
Feb 10, 2026
ned-deily
pushed a commit
that referenced
this pull request
Feb 10, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
--disable-pip-version-checkto the pip invocation that upgradescertifiinInstall Certificates.command, to avoid warnings like this:Docs: https://pip.pypa.io/en/stable/cli/pip/#cmdoption-disable-pip-version-check
These sometimes show up on GitHub Actions as part of
actions/setup-python, which I as an end user has little control over. And the funny thing is, that action had just upgraded pip right before callingInstall Certificates.command. See python-pillow/Pillow#9424 (comment) for more details.I think avoiding the warning in this script is okay. In normal use, the user double clicks the "Install Certificates.command" icon during installation, the default terminal upgrades certifi then terminates.
People will still see the warning later on regular pip invocations when they're in a normal terminal session, which is when they can actually do something about it.
(Let me know if this PR needs an issue or news.)