gh-145854: Replace DELETE_NAME with PUSH_NULL; STORE_NAME#146006
Open
brijkapadia wants to merge 7 commits intopython:mainfrom
Open
gh-145854: Replace DELETE_NAME with PUSH_NULL; STORE_NAME#146006brijkapadia wants to merge 7 commits intopython:mainfrom
DELETE_NAME with PUSH_NULL; STORE_NAME#146006brijkapadia wants to merge 7 commits intopython:mainfrom
Conversation
Changes - Removed `DELETE_NAME` - When `STORE_NAME` receives a `NULL` value, it corresponds with deletion
brijkapadia
requested review from
ericsnowcurrently,
iritkatriel and
markshannon
as code owners
Contributor
Author
|
I am not sure why three of the CIFuzz tests fail. If anyone could help, that would be appreciated. |
picnixz
reviewed
Mar 16, 2026
picnixz
reviewed
Mar 16, 2026
Member
|
This will need a magic number bump (as do all changes that add or remove opcodes) |
markshannon
approved these changes
Mar 17, 2026
Member
markshannon
left a comment
markshannon
left a comment
There was a problem hiding this comment.
Looks good. Thanks for doing this.
Contributor
Author
|
@markshannon A gentle reminder about this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
DELETE_NAMESTORE_NAMEreceives aNULLvalue, it corresponds with deletionDELETE_NAMEinstruction #145854📚 Documentation preview 📚: https://cpython-previews--146006.org.readthedocs.build/