gh-146458: Fix repl height and width tracking on resize

[GabrielvMarinho]

On windows, the resize event should be triggering an update in the console height and width, however this is not happening.

I noticed the Unix console didn't have this problem, it was updating fine. My suggestion to fixing this is taking the resizing logic from both console implementations and let it at the reader level, that way it will update both (Unix and windows).

After adding this change, the resizing was happening:

fixed-repl-video.mp4

The tests then started failing as the Magic Mocks to getheightwidth weren't actually returning a tuple with the height and width, so I changed it by adding the side_effect keyword and sending a lambda with the values. With that addition, the tests are actually testing if the resize is happening, if you comment out the height and width resizing logic, they will fail.

• Issue: REPL height and width tracking on resize are incorrect #146458

[python-cla-bot]

All commit authors signed the Contributor License Agreement.

[bedevere-app]

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

[bedevere-app]

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

[vstinner]

The CI is failing. Example:

======================================================================
ERROR: test_resize_bigger_on_multiline_function (test.test_pyrepl.test_unix_console.TestConsole.test_resize_bigger_on_multiline_function)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/cpython/cpython-ro-srcdir/Lib/unittest/mock.py", line 1439, in patched
    return func(*newargs, **newkeywargs)
  File "/home/runner/work/cpython/cpython-ro-srcdir/Lib/test/test_pyrepl/test_unix_console.py", line 263, in test_resize_bigger_on_multiline_function
    _, con = handle_all_events(
             ~~~~~~~~~~~~~~~~~^
        [Event(evt="resize", data=None)],
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        prepare_reader=same_reader,
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^
        prepare_console=same_console,
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    )
    ^
  File "/home/runner/work/cpython/cpython-ro-srcdir/Lib/test/test_pyrepl/support.py", line 105, in handle_all_events
    reader.handle1()
    ~~~~~~~~~~~~~~^^
  File "/home/runner/work/cpython/cpython-ro-srcdir/Lib/_pyrepl/reader.py", line 728, in handle1
    self.refresh()
    ~~~~~~~~~~~~^^
  File "/home/runner/work/cpython/cpython-ro-srcdir/Lib/_pyrepl/reader.py", line 647, in refresh
    self.console.height, self.console.width = self.console.getheightwidth()
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ValueError: not enough values to unpack (expected 2, got 0)

======================================================================
ERROR: test_resize_smaller_on_multiline_function (test.test_pyrepl.test_unix_console.TestConsole.test_resize_smaller_on_multiline_function)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/cpython/cpython-ro-srcdir/Lib/unittest/mock.py", line 1439, in patched
    return func(*newargs, **newkeywargs)
  File "/home/runner/work/cpython/cpython-ro-srcdir/Lib/test/test_pyrepl/test_unix_console.py", line 299, in test_resize_smaller_on_multiline_function
    _, con = handle_all_events(
             ~~~~~~~~~~~~~~~~~^
        [Event(evt="resize", data=None)],
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        prepare_reader=same_reader,
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^
        prepare_console=same_console,
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    )
    ^
  File "/home/runner/work/cpython/cpython-ro-srcdir/Lib/test/test_pyrepl/support.py", line 105, in handle_all_events
    reader.handle1()
    ~~~~~~~~~~~~~~^^
  File "/home/runner/work/cpython/cpython-ro-srcdir/Lib/_pyrepl/reader.py", line 728, in handle1
    self.refresh()
    ~~~~~~~~~~~~^^
  File "/home/runner/work/cpython/cpython-ro-srcdir/Lib/_pyrepl/reader.py", line 647, in refresh
    self.console.height, self.console.width = self.console.getheightwidth()
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ValueError: not enough values to unpack (expected 2, got 0)

[bedevere-app]

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

[bedevere-app]

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

[vstinner]

If possible, try to avoid git push --force, it makes reviews harder.

[GabrielvMarinho]

If possible, try to avoid git push --force, it makes reviews harder.

I had to git push --force some few times because i was rebasing, so its preferable to merge and do a new commit to get to the new state of the main?

[vstinner]

so its preferable to merge and do a new commit to get to the new state of the main?

Yes, merge is preferred. Rebase is also causing troubles in reviews.

[GabrielvMarinho]

so its preferable to merge and do a new commit to get to the new state of the main?

Yes, merge is preferred. Rebase is also causing troubles in reviews.

Thanks for the heads up, let me know if you need any help on the code review process.

[vstinner]

LGTM. unix_console and window_console generates "resize" events. Before, the window_console didn't update the console height and width. Now, the code is generic in Reader.refresh().

[vstinner]

You may add a NEWS entry to describe the fix.

[GabrielvMarinho]

You may add a NEWS entry to describe the fix.

I just added it, is it OK that way?