Skip to content

gh-146498: Ensure binary content is correctly processed in multi-arch iOS XCframeworks#146499

Merged
freakboy3742 merged 2 commits intopython:mainfrom
freakboy3742:xcframework-libpython
Mar 27, 2026
Merged

gh-146498: Ensure binary content is correctly processed in multi-arch iOS XCframeworks#146499
freakboy3742 merged 2 commits intopython:mainfrom
freakboy3742:xcframework-libpython

Conversation

@freakboy3742
Copy link
Copy Markdown
Contributor

@freakboy3742 freakboy3742 commented Mar 26, 2026 •
edited by bedevere-app bot
Loading

Modifies the iOS XCframework processing script so that:

  1. The libpython dylib is explicitly excluded from being copied, no matter whether the framework is thin or multi-arch
  2. The identification mechanism that looks for the standard library is more robust to additional content in the folder.

@bedevere-app bedevere-app bot mentioned this pull request Mar 26, 2026
Closed
@freakboy3742 freakboy3742 added needs backport to 3.14 bugs and security fixes and removed awaiting core review labels Mar 26, 2026
@freakboy3742 freakboy3742 requested a review from ned-deily March 26, 2026 23:46
@freakboy3742 freakboy3742 mentioned this pull request Mar 27, 2026
Merged
ned-deily
ned-deily approved these changes Mar 27, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@ned-deily ned-deily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM without testing

@freakboy3742 freakboy3742 merged commit 5684b3a into python:main Mar 27, 2026
37 checks passed
@freakboy3742 freakboy3742 deleted the xcframework-libpython branch March 27, 2026 01:56
@miss-islington-app
Copy link
Copy Markdown

miss-islington-app bot commented Mar 27, 2026

Thanks @freakboy3742 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 27, 2026
@freakboy3742 @miss-islington
pythongh-146498: Ensure binary content is correctly processed in mult…
a10301e 
…i-arch iOS XCframeworks (pythonGH-146499)

Ensure that multi-arch libpython dylibs aren't copied into the app, and the
standard lib is always found for framework post-processing.
(cherry picked from commit 5684b3a)

Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
@bedevere-app
Copy link
Copy Markdown

bedevere-app bot commented Mar 27, 2026

GH-146502 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Mar 27, 2026
freakboy3742 added a commit that referenced this pull request Mar 27, 2026
@miss-islington @freakboy3742
[3.14] gh-146498: Ensure binary content is correctly processed in mul…
74c21ae 
…ti-arch iOS XCframeworks (GH-146499) (#146502)

Ensure that multi-arch libpython dylibs aren't copied into the app, and the
standard lib is always found for framework post-processing.
(cherry picked from commit 5684b3a)

Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ned-deily ned-deily ned-deily approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@freakboy3742 @ned-deily