Skip to content

gh-138580: revert PR 138811#146501

Merged
vstinner merged 1 commit intopython:mainfrom
skirpichev:revert-68c7fad757f/138580
Mar 27, 2026
Merged

gh-138580: revert PR 138811#146501
vstinner merged 1 commit intopython:mainfrom
skirpichev:revert-68c7fad757f/138580

Conversation

@skirpichev
Copy link
Copy Markdown
Member

@skirpichev skirpichev commented Mar 27, 2026

This reverts commit 68c7fad.

It looks like on practice the __STDC_IEC_559__ doesn't indicate conformance to the standard. It can't be used to filter out tests or to give some promises in documentation. See discussion in the reverted PR thread:
#138811 (comment)


📚 Documentation preview 📚: https://cpython-previews--146501.org.readthedocs.build/

@skirpichev
Copy link
Copy Markdown
Member Author

CC @vstinner

@vstinner
Copy link
Copy Markdown
Member

Can you please provide a rationale for the revert? So I can put it in the commit message.

@skirpichev
Copy link
Copy Markdown
Member Author

Description updated.

@vstinner vstinner merged commit 256907d into python:main Mar 27, 2026
54 checks passed
@skirpichev skirpichev deleted the revert-68c7fad757f/138580 branch March 27, 2026 10:30
@vstinner
Copy link
Copy Markdown
Member

Ok, I merged the PR to revert the flag. Bye bye ISO/IEC 60559.

@skirpichev
Copy link
Copy Markdown
Member Author

skirpichev commented Mar 27, 2026 via email

@vstinner
Copy link
Copy Markdown
Member

Hum, I also expect that it's a lot of work to make sure that libm implementation is fully compliant. And it seems like not all libm maintainers can enough to do this work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants