[mypyc] Add inline primitives for bytes.__getitem__ #20552
Merged
+143
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # mypyc/irbuild/specialize.py
p-sawicki
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are similar to the ones we have for
BytesWriter. These are a bit faster that the old primitive in typical cases (based on a microbenchmark), but in an ideal scenario these allow vectorization by the C compiler and something like 10x performance improvement.I don't remove the old primitive yet, since it's used in some places which can't currently use the specializer. I'll look at running the specializer in more contexts as a follow-up PR. This PR should cover some of the most common use cases.
Also refactor to share some code with
BytesWriterspecialization.