Skip to content

[select] Mark select.poll as @final#15759

Merged
srittau merged 1 commit into
mainfrom
sobolevn-patch-2
May 11, 2026
Merged

[select] Mark select.poll as @final#15759
srittau merged 1 commit into
mainfrom
sobolevn-patch-2

Conversation

@sobolevn
Copy link
Copy Markdown
Member

See:

>>> import select
>>> t = type(select.poll())
>>> t
<class 'select.poll'>
>>> class a(t): ...
... 
Traceback (most recent call last):
  File "<python-input-11>", line 1, in <module>
    class a(t): ...
TypeError: type 'select.poll' is not an acceptable base type

See:

```python
>>> import select
>>> t = type(select.poll())
>>> t
<class 'select.poll'>
>>> class a(t): ...
... 
Traceback (most recent call last):
  File "<python-input-11>", line 1, in <module>
    class a(t): ...
TypeError: type 'select.poll' is not an acceptable base type
```
@github-actions
Copy link
Copy Markdown
Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

pandas (https://github.com/pandas-dev/pandas)
- pandas/core/computation/ops.py:328: error: Need type annotation for "_binary_ops_dict" (hint: "_binary_ops_dict: dict[<type>, <type>] = ...")  [var-annotated]

@srittau srittau merged commit ea144d3 into main May 11, 2026
56 checks passed
@srittau srittau deleted the sobolevn-patch-2 branch May 11, 2026 11:08
tkem pushed a commit to tkem/typeshed that referenced this pull request May 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants