Skip to content

Parametrize click.types.ParamType as base class in click_web.web_click_types #15803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 5 commits into from
May 17, 2026
Merged

Parametrize click.types.ParamType as base class in click_web.web_click_types #15803

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
61b7ca8
commit
jonathandung May 17, 2026
b928fee
commit 2
jonathandung May 17, 2026
1c85d0b
commit 3
jonathandung May 17, 2026
58f3b98
commit 4
jonathandung May 17, 2026
e42f6e7
commit 5
jonathandung May 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions stubs/click-web/click_web/resources/input_fields.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ class FieldId:
class NotSupported(ValueError): ...

class BaseInput:
param_type_cls: type[click.types.ParamType] | None
param_type_cls: type[click.types.ParamType[Any]] | None
ctx: click.Context
param: click.Parameter
command_index: int
Expand Down Expand Up @@ -73,7 +73,7 @@ class TextAreaInput(BaseInput):
param_type_cls: type[TextAreaParamType]

class DefaultInput(BaseInput):
param_type_cls: type[click.ParamType]
param_type_cls: type[click.ParamType[Any]]

INPUT_TYPES: Final[list[type[BaseInput]]]
_DEFAULT_INPUT: Final[list[type[DefaultInput]]]
Expand Down
8 changes: 4 additions & 4 deletions stubs/click-web/click_web/web_click_types.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
import re
from typing import ClassVar, TypeVar
from typing import Any, ClassVar, TypeVar

import click

_T = TypeVar("_T")

class EmailParamType(click.ParamType):
class EmailParamType(click.ParamType[str]):
EMAIL_REGEX: ClassVar[re.Pattern[str]]
def convert(self, value: str, param: click.Parameter | None, ctx: click.Context | None) -> str: ...

class PasswordParamType(click.ParamType):
class PasswordParamType(click.ParamType[Any]):
def convert(self, value: _T, param: click.Parameter | None, ctx: click.Context | None) -> _T: ...

class TextAreaParamType(click.ParamType):
class TextAreaParamType(click.ParamType[Any]):
def convert(self, value: _T, param: click.Parameter | None, ctx: click.Context | None) -> _T: ...

EMAIL_TYPE: EmailParamType
Expand Down
Loading