Skip to content

Import pycon-styleguide repo as styleguide/ subfolder#4671

Open
marcoacierno wants to merge 461 commits into
mainfrom
import-styleguide
Open

Import pycon-styleguide repo as styleguide/ subfolder#4671
marcoacierno wants to merge 461 commits into
mainfrom
import-styleguide

Conversation

@marcoacierno

Copy link
Copy Markdown
Member

Summary

Imports the pycon-styleguide repository into the monorepo as a styleguide/ subfolder, preserving its full git history (567 commits).

How

  • Cloned the styleguide repo and rewrote its history with git-filter-repo --to-subdirectory-filter styleguide, so all historical paths live under styleguide/
  • Merged into this repo with git merge --allow-unrelated-histories

git log styleguide/ and git log --follow on individual files work as expected.

Notes

  • styleguide/.github/workflows/ (deploy, commands, dependabot) came along with the import. These are inert in the monorepo (GitHub only reads root .github/workflows) — the old npm publish workflow should be ported or removed in a follow-up.
  • Follow-ups: wire styleguide into the pnpm workspace, point the frontend at the local package instead of the published @python-italia/pycon-styleguide, archive the old repo.

🤖 Generated with Claude Code

pythonitaliabot and others added 30 commits December 28, 2022 17:40
@vercel

vercel Bot commented Jun 13, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
pycon Error Error Jun 13, 2026 1:24am

@claude

claude Bot commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

This PR imports the pycon-styleguide repository as a styleguide/ subfolder in the monorepo.

Issues Found

Critical: Deploy workflow won't trigger on styleguide changes

styleguide/.github/workflows/deploy.yml lines 9-13 — GitHub path filters are relative to the repository root, but the paths listed still reference the old root-level layout:

paths:
  - "src/**/*"
  - "package.json"

These should be prefixed with styleguide/:

paths:
  - "styleguide/src/**/*"
  - "styleguide/package.json"

The deploy workflow will never trigger on pushes to main that only touch styleguide/.

Critical: Missing working directory in deploy steps

None of the build/publish steps in styleguide/.github/workflows/deploy.yml specify a working directory. Since pnpm/action-setup with run_install: true installs at the repo root, commands like pnpm version patch, pnpm publish, and git add package.json (lines ~78-108) will execute against the root package.json, not the styleguide's. Every shell step needs either working-directory: styleguide or an explicit cd styleguide &&.

High: Duplicate slash-command workflows

styleguide/.github/workflows/commands.yml duplicates the root .github/workflows/slash-commands.yml — same trigger (on: issue_comment), same name ("Slash Command Dispatch"). GitHub only processes workflows under root .github/workflows/, so the nested one is inert, but it creates confusion and references secrets.BOT_TOKEN that will never be evaluated. Delete styleguide/.github/workflows/ entirely.

Medium: date-fns major version incompatibility

Styleguide declares "date-fns": "^2.28.0" as a peer dependency, but the frontend uses date-fns ^4.3.0. v2 and v4 have breaking API changes. The styleguide's peer dependency range should be updated to accept v4 or document that it's incompatible.

Medium: React type definition conflict

Styleguide depends on "@types/react": "^17.0.80" while the frontend pins "@types/react": "19.0.1" globally. This will produce type conflicts in the monorepo if both packages share the same node_modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants