Fix buffer size for reading processor core id#352
Merged
GregoryComer merged 1 commit intopytorch:mainfrom Jan 30, 2026
Merged
Conversation
fbarchard
approved these changes
Jan 6, 2026
Collaborator
fbarchard
left a comment
fbarchard
left a comment
There was a problem hiding this comment.
Thanks for spotting the wrong name
Collaborator
|
This bug fix still looks good to me. |
GregoryComer
approved these changes
Jan 30, 2026
Member
|
@redwanulsourav Can you rebase the PR? I can go ahead and merge it if CI is clean post-rebase. |
Contributor
Author
Yes! I am working on it. |
redwanulsourav
force-pushed
the
fix_buffer_size_processor_core_id
branch
from
5ddceba to
a8d15cf
Compare
Contributor
Author
|
@GregoryComer I rebased the PR onto the latest main. Could you please take another look and confirm everything looks good? |
Member
|
CI looks good. I'll go ahead and merge. Thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cpuinfo_linux_get_processor_core_id,snprintfis called with buffer size CORE_ID_FILENAME_SIZE.This PR fixes the array size to CORE_ID_FILENAME_SIZE.