Bugfix: training header files were not installed with "make install".#18004
Open
berndporr wants to merge 5 commits intopytorch:mainfrom
Open
Bugfix: training header files were not installed with "make install".#18004berndporr wants to merge 5 commits intopytorch:mainfrom
berndporr wants to merge 5 commits intopytorch:mainfrom
Conversation
Fixes bug reported here: pytorch#17979 These files were not installed with "make install": executorch/extension/training/module/state_dict_util.h executorch/extension/training/module/training_module.h executorch/extension/training/optimizer/sgd.h This commit fixes this by adding the appropriate install commands.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18004
Note: Links to docs will display an error until the docs builds have been completed.
|
meta-cla
bot
added
the
CLA Signed
Author
|
@pytorchbot label "release notes: training" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes bug reported here: #17979
These files were not installed with "make install":
executorch/extension/training/module/state_dict_util.h
executorch/extension/training/module/training_module.h
executorch/extension/training/optimizer/sgd.h
This commit fixes this by adding the appropriate install commands.
Adding @JacobSzwejbka to the conversation.