Skip to content

Qualcomm AI Engine Direct - Custom op example fixes#18024

Open
qti-mmadhava wants to merge 1 commit intopytorch:mainfrom
CodeLinaro:dev1/mmadhava/custom_op_fixes
Open

Qualcomm AI Engine Direct - Custom op example fixes#18024
qti-mmadhava wants to merge 1 commit intopytorch:mainfrom
CodeLinaro:dev1/mmadhava/custom_op_fixes

Conversation

@qti-mmadhava
Copy link

@qti-mmadhava qti-mmadhava commented Mar 9, 2026

Qualcomm AI Engine Direct - Custom op example fixes

Summary

  • Fixed bug in custom_op example, where use_fp16 was failing, due to quantizer being called.
  • Set LD_LIBRARY_PATH and ADSP_LIBRARY_PATH prior to executing on-device.
  • Added debug flag to custom_op example, so that DSP logs are captured by adb logcat

Test plan

python3 examples/qualcomm/custom_op/custom_ops_1.py --build_folder build-android -s $ANDROID_SERIAL -H $ADB_HOST -m SM8650 --op_package_dir examples/qualcomm/custom_op/example_op_package_htp/ExampleOpPackage --build_op_package --debug --use_fp16

cc @cccclai @cbilgin

- Fixed bug in custom_op example, with use_fp16 flag
- Set LD_LIBRARY_PATH and ADSP_LIBRARY_PATH when executing on-device
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 9, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18024

Note: Links to docs will display an error until the docs builds have been completed.

❌ 56 New Failures, 2 Unrelated Failures

As of commit eeff431 with merge base 47b8d1d (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 9, 2026
@qti-mmadhava qti-mmadhava changed the title Qualcomm AI Engine Direct - Custom op example fixes and improvements Qualcomm AI Engine Direct - Custom op example fixes Mar 9, 2026
@github-actions
Copy link

github-actions bot commented Mar 9, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@qti-mmadhava
Copy link
Author

Hi @cccclai, @abhinaykukkadapu,
This PR includes some minor fixes and updates to the qualcomm custom_op example.
When you have time, could you please help review?
Thanks

@digantdesai digantdesai added the module: qnn Issues related to Qualcomm's QNN delegate and code under backends/qualcomm/ label Mar 10, 2026
@digantdesai
Copy link
Contributor

PR looks ok. Are the CI failures unrelated?

@abhinaykukkadapu
Copy link
Contributor

@digantdesai I think it is based on a very old base

It’s [521 commits](https://github.com/pytorch/executorch/compare/6abcb53b...main) behind (base commit: https://github.com/pytorch/executorch/commit/6abcb53bf029e2e66793b234bd96384d54620bf6)
Hang in there while we check the branch's status.

@qti-mmadhava can you pull and rebase to main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: qnn Issues related to Qualcomm's QNN delegate and code under backends/qualcomm/

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants