Add WASM/Emscripten compiler flags to runtime_wrapper.bzl#18025
Merged
meta-codesync[bot] merged 1 commit intopytorch:mainfrom Mar 10, 2026
Merged
Add WASM/Emscripten compiler flags to runtime_wrapper.bzl#18025meta-codesync[bot] merged 1 commit intopytorch:mainfrom
meta-codesync[bot] merged 1 commit intopytorch:mainfrom
Conversation
Summary: Add pthread compiler flags (-pthread, -matomics, -mbulk-memory) for Emscripten/WASM builds in ExecuTorch runtime wrapper. These flags are required when linking into WASM binaries that use -sUSE_PTHREADS=1. Without them, wasm-ld fails with: "error: --shared-memory is disallowed by <file>.o because it was not compiled with 'atomics' or 'bulk-memory' features." Reviewed By: GregoryComer Differential Revision: D95904580
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18025
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New FailuresAs of commit cf8d6ed with merge base 7824373 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
Contributor
Author
|
@pytorchbot label "release notes: build" |
GregoryComer
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Add pthread compiler flags (-pthread, -matomics, -mbulk-memory) for
Emscripten/WASM builds in ExecuTorch runtime wrapper.
These flags are required when linking into WASM binaries that use
-sUSE_PTHREADS=1. Without them, wasm-ld fails with:
"error: --shared-memory is disallowed by .o because it was not
compiled with 'atomics' or 'bulk-memory' features."
Reviewed By: GregoryComer
Differential Revision: D95904580