[ET-VK] Add ANY_STORAGE support to argmax and argmin#18058
Open
SS-JIA wants to merge 1 commit intogh/SS-JIA/475/basefrom
Open
[ET-VK] Add ANY_STORAGE support to argmax and argmin#18058SS-JIA wants to merge 1 commit intogh/SS-JIA/475/basefrom
SS-JIA wants to merge 1 commit intogh/SS-JIA/475/basefrom
Conversation
Register argmax and argmin as ANY_STORAGE. The existing shaders and C++ dispatch already handle buffer storage via pick_storage_for_reduce. Differential Revision: [D95970165](https://our.internmc.facebook.com/intern/diff/D95970165/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18058
Note: Links to docs will display an error until the docs builds have been completed. ❌ 5 New Failures, 1 Unrelated FailureAs of commit 8284fd9 with merge base f09bd55 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
This was referenced Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Register argmax and argmin as ANY_STORAGE. The existing shaders and
C++ dispatch already handle buffer storage via pick_storage_for_reduce.
Differential Revision: D95970165