Skip to content

Add bounds check for constant_data offset#19285

Open
rascani wants to merge 1 commit intopytorch:mainfrom
rascani:export-D103467781
Open

Add bounds check for constant_data offset#19285
rascani wants to merge 1 commit intopytorch:mainfrom
rascani:export-D103467781

Conversation

@rascani
Copy link
Copy Markdown
Contributor

@rascani rascani commented May 4, 2026

Summary:
Validate that constant_data_offset->offset() does not exceed constant_data_size before computing constant_data_ptr + offset in getConstantDataPtr().

Previously, the offset read from the flatbuffer was used in pointer arithmetic with no validation. A crafted XNNPACK delegate blob could set an arbitrary offset, causing an out-of-bounds read relative to constant_data_ptr. The main ExecuTorch runtime already performs this check in program.cpp:get_constant_buffer_data() — the XNNPACK backend was missing the equivalent.

Thread constant_data_size from the XNNHeader (which already parses and validates it) through compileModel()defineTensor()getConstantDataPtr().

MACA-2026-001 (T267371218).

Differential Revision: D103467781

Summary:
Validate that `constant_data_offset->offset()` does not exceed `constant_data_size` before computing `constant_data_ptr + offset` in `getConstantDataPtr()`.

Previously, the offset read from the flatbuffer was used in pointer arithmetic with no validation. A crafted XNNPACK delegate blob could set an arbitrary offset, causing an out-of-bounds read relative to `constant_data_ptr`. The main ExecuTorch runtime already performs this check in `program.cpp:get_constant_buffer_data()` — the XNNPACK backend was missing the equivalent.

Thread `constant_data_size` from the `XNNHeader` (which already parses and validates it) through `compileModel()` → `defineTensor()` → `getConstantDataPtr()`.

MACA-2026-001 (T267371218).

Differential Revision: D103467781
@rascani rascani requested a review from digantdesai as a code owner May 4, 2026 21:42
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented May 4, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19285

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 2 New Failures, 4 Unrelated Failures

As of commit ae4ce19 with merge base 2050b8a (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 4, 2026
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented May 4, 2026

@rascani has exported this pull request. If you are a Meta employee, you can view the originating Diff in D103467781.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant