Qualcomm AI Engine Direct - Updating Claude skill for new op development#19302
Open
qti-horodnic wants to merge 1 commit intopytorch:mainfrom
Open
Qualcomm AI Engine Direct - Updating Claude skill for new op development#19302qti-horodnic wants to merge 1 commit intopytorch:mainfrom
qti-horodnic wants to merge 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19302
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below:
|
Contributor
Author
|
@pytorchbot label "release notes: qualcomm" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updated the Claude skill for adding new op support based on my findings from manually implementing ~15 previous ops, including corner cases, bugs I've run into before and comments I've gotten on previous prs.
Test plan
Implemented the
tanop using this skill only: #19301