Skip to content

Revert the code change block qnn lowering #19307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
billmguo wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −11
Open

Revert the code change block qnn lowering #19307

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 4 additions & 11 deletions examples/models/llama/static_attention.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
)
from executorch.examples.models.llama.lora import LoRALinear
from executorch.examples.models.llama.model_args import ModelArgs
from executorch.examples.models.llama.norm import ScalelessRMSNorm

Check warning on line 18 in examples/models/llama/static_attention.py

View workflow job for this annotation

GitHub Actions / lintrunner

FLAKE8 F401 

'executorch.examples.models.llama.norm.ScalelessRMSNorm' imported but unused
See https://www.flake8rules.com/rules/F401.html.
from executorch.examples.models.llama.rope import Rope


Expand Down Expand Up @@ -898,18 +898,11 @@

def _init_qk_norms(self, config: ModelArgs, is_kv_shared_layer: bool) -> None:
if self.use_qk_norm:
if getattr(config, "qk_norm_affine", True):
self.q_norm = torch.nn.RMSNorm(self.head_dim, config.norm_eps)
if is_kv_shared_layer:
self.k_norm = nn.Identity()
else:
self.k_norm = torch.nn.RMSNorm(self.head_dim, config.norm_eps)
self.q_norm = torch.nn.RMSNorm(self.head_dim, config.norm_eps)
if is_kv_shared_layer:
self.k_norm = nn.Identity()
else:
self.q_norm = ScalelessRMSNorm(self.head_dim, eps=config.norm_eps)
if is_kv_shared_layer:
self.k_norm = nn.Identity()
else:
self.k_norm = ScalelessRMSNorm(self.head_dim, eps=config.norm_eps)
self.k_norm = torch.nn.RMSNorm(self.head_dim, config.norm_eps)
else:
self.q_norm = torch.nn.Identity()
self.k_norm = torch.nn.Identity()
Expand Down
Loading