Skip to content

bypass add and addRelu that have inputs from non-dq nodes#19315

Open
rezaasjd wants to merge 1 commit intopytorch:mainfrom
rezaasjd:export-D103949573
Open

bypass add and addRelu that have inputs from non-dq nodes#19315
rezaasjd wants to merge 1 commit intopytorch:mainfrom
rezaasjd:export-D103949573

Conversation

@rezaasjd
Copy link
Copy Markdown
Contributor

@rezaasjd rezaasjd commented May 5, 2026

Summary:
The QuantFusion pass in crashes when an add node's inputs aren't dequantize_per_tensor ops. QAT model produces exactly this pattern.
The dequants_inputs list ends up empty, and get_args_and_kwargs_add() indexes [0].

Differential Revision: D103949573

Summary:
The QuantFusion pass in crashes when an add node's inputs aren't dequantize_per_tensor ops. QAT model produces exactly this pattern.
The dequants_inputs list ends up empty, and get_args_and_kwargs_add() indexes [0].

Differential Revision: D103949573
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented May 5, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19315

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Awaiting Approval, 2 New Failures, 4 Unrelated Failures

As of commit 0758007 with merge base 5d07ce0 (image):

AWAITING APPROVAL - The following workflow needs approval before CI can run:

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 5, 2026
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented May 5, 2026

@rezaasjd has exported this pull request. If you are a Meta employee, you can view the originating Diff in D103949573.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant