Make EAGLE-3 chain length K a runtime parameter#20345
Open
digantdesai wants to merge 2 commits into
Open
Conversation
Contributor
Author
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20345
Note: Links to docs will display an error until the docs builds have been completed. ❗ 2 Active SEVsThere are 2 currently active SEVs. If your PR is affected, please view them below:
❌ 1 Cancelled Job, 1 Unrelated Failure, 3 Unclassified FailuresAs of commit 7e71c78 with merge base da9158b ( UNCLASSIFIED FAILURES - DrCI could not classify the following jobs because the workflow did not run on the merge base. The failures may be pre-existing on trunk or introduced by this PR:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
target_verify was exported at a static T = chain+1, so K was baked into the .pte
and changing it meant a full re-export. Export the verify window as a dynamic dim
T in [2, MATVEC_MAX_M] instead, so one .pte serves any K in [1, MATVEC_MAX_M - 1]
and the runner selects it with --chain (get_chain_len is only the default). The
verify M never straddles the INT4 dispatch threshold (max == MATVEC_MAX_M), so it
resolves to the small-M GEMM over the whole range, and the mid-M SDPA kernel
takes M as a runtime arg. The gemma4 mask traces correctly down to T=2; the
target's min_forward_len=5 was a conservative prefill note and does not bound
verify.
Authored with assistance from Claude Code.