Skip to content

Make EAGLE-3 chain length K a runtime parameter#20345

Open
digantdesai wants to merge 2 commits into
gh/digantdesai/63/headfrom
gh/digantdesai/64/head
Open

Make EAGLE-3 chain length K a runtime parameter#20345
digantdesai wants to merge 2 commits into
gh/digantdesai/63/headfrom
gh/digantdesai/64/head

Conversation

@digantdesai

Copy link
Copy Markdown
Contributor

target_verify was exported at a static T = chain+1, so K was baked into the .pte
and changing it meant a full re-export. Export the verify window as a dynamic dim
T in [2, MATVEC_MAX_M] instead, so one .pte serves any K in [1, MATVEC_MAX_M - 1]
and the runner selects it with --chain (get_chain_len is only the default). The
verify M never straddles the INT4 dispatch threshold (max == MATVEC_MAX_M), so it
resolves to the small-M GEMM over the whole range, and the mid-M SDPA kernel
takes M as a runtime arg. The gemma4 mask traces correctly down to T=2; the
target's min_forward_len=5 was a conservative prefill note and does not bound
verify.

Authored with assistance from Claude Code.

[ghstack-poisoned]
@pytorch-bot

pytorch-bot Bot commented Jun 17, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20345

Note: Links to docs will display an error until the docs builds have been completed.

❗ 2 Active SEVs

There are 2 currently active SEVs. If your PR is affected, please view them below:

❌ 1 Cancelled Job, 1 Unrelated Failure, 3 Unclassified Failures

As of commit 7e71c78 with merge base da9158b (image):

UNCLASSIFIED FAILURES - DrCI could not classify the following jobs because the workflow did not run on the merge base. The failures may be pre-existing on trunk or introduced by this PR:

CANCELLED JOB - The following job was cancelled. Please retry:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[ghstack-poisoned]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant