Skip to content

Fix buck dep for test_permute_optimization_passes (#20497)#20497

Open
digantdesai wants to merge 1 commit into
pytorch:mainfrom
digantdesai:export-D109619313
Open

Fix buck dep for test_permute_optimization_passes (#20497)#20497
digantdesai wants to merge 1 commit into
pytorch:mainfrom
digantdesai:export-D109619313

Conversation

@digantdesai

@digantdesai digantdesai commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Summary:

D109300695 (GitHub PR #19873) added a new test test_postpone_permute_with_symbolic_shapes that imports to_edge and EdgeCompileConfig from executorch.exir, but the test_permute_optimization_passes buck test target was never updated to depend on //executorch/exir:lib (the owner of executorch/exir/__init__.py). As a result the entire test module failed to import (Failed to import test module: test_permute_optimization_passes), turning every test in the module into a land-blocking CRITICAL signal on the diff train.

Add the missing //executorch/exir:lib dep to both the fbcode and xplat copies of backends/transforms/targets.bzl so the two mirrors stay in sync.

Reviewed By: Gasoonjia

Differential Revision: D109619313

@digantdesai digantdesai requested a review from kimishpatel as a code owner June 24, 2026 22:26
Copilot AI review requested due to automatic review settings June 24, 2026 22:26
@pytorch-bot

pytorch-bot Bot commented Jun 24, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20497

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 2 New Failures, 2 Unrelated Failures

As of commit e4ebbba with merge base 45a14b9 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 24, 2026
@meta-codesync

meta-codesync Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

@digantdesai has exported this pull request. If you are a Meta employee, you can view the originating Diff in D109619313.

@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes Buck build/test configuration for backends/transforms/test/test_permute_optimization_passes.py, which now imports to_edge / EdgeCompileConfig from executorch.exir and therefore requires the //executorch/exir:lib target (the owner of exir/__init__.py) to be present in the test’s deps.

Changes:

  • Add missing //executorch/exir:lib dependency to the test_permute_optimization_passes Buck runtime.python_test target.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Summary:
Pull Request resolved: pytorch#20497

D109300695 (GitHub PR pytorch#19873) added a new test `test_postpone_permute_with_symbolic_shapes` that imports `to_edge` and `EdgeCompileConfig` from `executorch.exir`, but the `test_permute_optimization_passes` buck test target was never updated to depend on `//executorch/exir:lib` (the owner of `executorch/exir/__init__.py`). As a result the entire test module failed to import (`Failed to import test module: test_permute_optimization_passes`), turning every test in the module into a land-blocking CRITICAL signal on the diff train.

Add the missing `//executorch/exir:lib` dep to both the `fbcode` and `xplat` copies of `backends/transforms/targets.bzl` so the two mirrors stay in sync.

Reviewed By: Gasoonjia

Differential Revision: D109619313
@meta-codesync meta-codesync Bot changed the title Fix buck dep for test_permute_optimization_passes Fix buck dep for test_permute_optimization_passes (#20497) Jun 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants