Skip to content

Use whole data from PTI activity record#1278

Closed
moksiuc wants to merge 3 commits intopytorch:mainfrom
aostrowski-hbn:moksiuci_8273_use_whole_pti_records
Closed

Use whole data from PTI activity record#1278
moksiuc wants to merge 3 commits intopytorch:mainfrom
aostrowski-hbn:moksiuci_8273_use_whole_pti_records

Conversation

@moksiuc
Copy link
Copy Markdown
Contributor

@moksiuc moksiuc commented Feb 27, 2026

Use whole data from PTI activity record for json event metadata. The exemplary json entry would look like:

{
"ph": "X", "cat": "kernel", "name": "gemm_kernel", "pid": 0, "tid": 64,
"ts": 4998378035536.824, "dur": 12.320,
"args": {
"External id": 2,
"sycl_node_id": 394900016,
"kernel_id": 11,
"l0 queue": "0x00000000172ac848",
"device": 0, "correlation": 12616,
"context": "0x000000001292ef08",
"sycl queue": 64
"sycl_invocation_id": 1,
"sycl_task_begin": "4998378035116.909",
"sycl_enqk_begin": "4998378035152.331",
"appended": "4998378035418.264",
"submitted": "4998378035418.264",
"sycl_task_begin_rel_to_start": "-419.915",
"sycl_enqk_begin_rel_to_start": "-384.493",
"appended_rel_to_start": "-118.560",
"submitted_rel_to_start": "-118.560",
"source_file_name": "",
"source_line_number": 0,
}
},

Use whole data from PTI activity record for json event metadata.
@meta-cla meta-cla Bot added the cla signed label Feb 27, 2026
@moksiuc
Copy link
Copy Markdown
Contributor Author

moksiuc commented Feb 27, 2026

@EikanWang, @gujinghui

@moksiuc
Copy link
Copy Markdown
Contributor Author

moksiuc commented Feb 27, 2026

I notice a lot of formatting issues. Could someone help what version of clang-format is used on CI ?
My formatting is obtained with lintrunner. clang-format in version 18.1.3.
I tried earlier version but it doesn't work with current .clang-format contents, for ex version 14 gives an error:
.clang-format:64:1: error: unknown key 'Macros'

@moksiuc
Copy link
Copy Markdown
Contributor Author

moksiuc commented Feb 27, 2026

XPU CI results: pytorch/pytorch#175974

Comment thread libkineto/src/plugin/xpupti/XpuptiActivityProfilerSession.h Outdated
Comment thread libkineto/src/plugin/xpupti/XpuptiActivityProfilerSession.h
@gujinghui
Copy link
Copy Markdown

@moksiuc do we have case to cover these code changes?

@moksiuc
Copy link
Copy Markdown
Contributor Author

moksiuc commented Mar 9, 2026

What kind of case do you mean ?
All that data may be useful for the user.

@gujinghui
Copy link
Copy Markdown

What kind of case do you mean ? All that data may be useful for the user.

Is there any kineto case to check the output items or formats?

@moksiuc
Copy link
Copy Markdown
Contributor Author

moksiuc commented Mar 10, 2026

It is all available as metadate in output json for perfetto, so every user can use this data as needed.

@gujinghui
Copy link
Copy Markdown

@sraikund16 @divyanshk @scotts
Could you help review? Thanks.

@meta-codesync
Copy link
Copy Markdown

meta-codesync Bot commented Mar 16, 2026

@divyanshk has imported this pull request. If you are a Meta employee, you can view this in D96775775.

@meta-codesync meta-codesync Bot closed this in c6c84d0 Mar 17, 2026
@meta-codesync
Copy link
Copy Markdown

meta-codesync Bot commented Mar 17, 2026

@divyanshk merged this pull request in c6c84d0.

@moksiuc moksiuc deleted the moksiuci_8273_use_whole_pti_records branch March 18, 2026 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants