[BugFix] Set "next" obs to current if native_autoreset#3786
Open
lin-erica wants to merge 5 commits into
Open
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/3786
Note: Links to docs will display an error until the docs builds have been completed. ❌ 6 New FailuresAs of commit 6c4605a with merge base 68f1ba5 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
theap06
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the "next" obs of the terminal state to the obs from the terminal state instead of setting it to NaN.
Motivation and Context
When using
native_autoresetthe next obs at a terminal state is set to NaN. However, this causes errors when calculating GAE. We could artificially replace it with a value likemissing_obs_value(e.g. setting it to 0), but could lead to confusion or silent errors potentially. This PR proposes to just set it to the current obs, as that is what is assumed when calculating GAE. We could consider removingauto_reset_envin GAE, but I'm keeping it in for now to allow the flexibility.Types of changes
What types of changes does your code introduce? Remove all that do not apply:
Checklist
Go over all the following points, and put an
xin all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!