Add CamX EL2 overlay#677
Add CamX EL2 overlay#677quic-vikramsa wants to merge 1 commit intoqualcomm-linux:tech/overlay/dtfrom
Conversation
quic-vikramsa
force-pushed
the
dt_overlay_kvm
branch
2 times, most recently
from
7a3be90 to
84247bf
Compare
shashim-quic
left a comment
shashim-quic
left a comment
There was a problem hiding this comment.
the approach to maintain camx overlay on top of kvm need to be discussed and aligned. Please schedule a meeting that included LE platform as well.
|
|
||
| &cam_icp_firmware { | ||
| camera-firmware { | ||
| iommus = <&apps_smmu 0x08C1 0x0400>; |
There was a problem hiding this comment.
0x08c1 , use small case hex numbers
| #include <dt-bindings/interrupt-controller/arm-gic.h> | ||
| #include <dt-bindings/power/qcom-rpmpd.h> | ||
|
|
||
| #include "lemans-camera.dtsi" |
There was a problem hiding this comment.
It is an overlay , why do we need to include whole lemans-camera support ?
Also this overlay is intended to be applied on what base ? i..e
- lemans-evk + lemans-evk-camx ? or
- lemans-evk ?
There was a problem hiding this comment.
Its intended as
lemans-evk + lemans-evk-cam-el2
There was a problem hiding this comment.
Its intended as lemans-evk + lemans-evk-cam-el2
and why not lemans-evk + lemans-evk-camx + lemans-evk-camx-el2 ?
| cam_sensor_active_rst0: cam-sensor-active-rst0 { | ||
| /* RESET */ | ||
| mux { | ||
| pins = "gpio132"; |
There was a problem hiding this comment.
why is gpio configuration impacted just because we are running under kvm ?
There was a problem hiding this comment.
This is not specific to kvm. lemans-evk-camx also have these
There was a problem hiding this comment.
This is not specific to kvm. lemans-evk-camx also have these
then what is the use of overlay. Try to bring overlay which carries things for its scope only.
|
|
||
| lemans-evk-camx-el2-dtbs:= lemans-evk-el2.dtb lemans-evk-camx-el2.dtbo | ||
|
|
||
| dtb-$(CONFIG_ARCH_QCOM) += lemans-evk-camx-el2.dtb |
There was a problem hiding this comment.
Do you need to generate dtb or just dtbo that can get overlaid at boot ? What is the plan and approach that has been discussed ?
There was a problem hiding this comment.
Currently we are generating a separate dtb for camx el2 which is (lemans-evk-camx.dtb + lemans-evk-camx-el2.dtbo) as this is the same way we used in 1.0. Your suggestion better in this case but that may need some rework to develop and test all scenarios. Can we work on this approach as a follow-up?
| #include <dt-bindings/interrupt-controller/arm-gic.h> | ||
| #include <dt-bindings/power/qcom-rpmpd.h> | ||
|
|
||
| #include "lemans-camera.dtsi" |
There was a problem hiding this comment.
why do we need to include full lemans-camera.dtsi for supporting overlay fragment.
There was a problem hiding this comment.
This is because we are generating a separate dtb for camx el2 which is (lemans-evk-camx.dtb + lemans-evk-camx-el2.dtbo)
quic-vikramsa
force-pushed
the
dt_overlay_kvm
branch
from
84247bf to
7c4dd1b
Compare
Add camx el2 DT overlay for lemans platforms. The overlay updates the ICP firmware node with Secure SMMU SID and disables secure QoS updates for CPAS in EL2/KVM configurations. Wire up the new overlay-built DTBs in the qcom DT Makefile so the corresponding *-camx-el2.dtb targets are generated. Co-developed-by: Ignatius Michael Jihan <mignatiu@qti.qualcomm.com> Signed-off-by: Ignatius Michael Jihan <mignatiu@qti.qualcomm.com> Signed-off-by: Vikram Sharma <vikramsa@qti.qualcomm.com>
quic-vikramsa
force-pushed
the
dt_overlay_kvm
branch
from
7c4dd1b to
34caf5f
Compare
3 participants
Add camx el2 DT overlay for lemans/sa8775p platforms.
The overlay updates the ICP firmware node with Secure SMMU SID and disables secure QoS updates for CPAS in EL2/KVM configurations.
Wire up the new overlay-built DTBs in the qcom DT Makefile so the corresponding *-camx-el2.dtb targets are generated.