Added Multimedia Video and Display GStreamer test scripts by nitinn22 · Pull Request #290 · qualcomm-linux/qcom-linux-testkit

nitinn22 · 2026-02-13T12:40:38Z

The scripts support GStreamer level validation for video and display,

Video: H.264/H.265/VP9 encode/decode with V4L2
Display: Wayland compositor validation

More info in their corresponding readme files.

Signed-off-by: Nitin Nakka <nitinn@qti.qualcomm.com>

…sing Signed-off-by: Nitin Nakka <nitinn@qti.qualcomm.com>

smuppand

Please move the generic helpers currently defined in Video_Encode_Decode/run.sh into Runner/utils/lib_gstreamer.sh so other GST tests can reuse them:
get_resolution_params() ->gstreamer_resolution_to_wh()
get_encoder_element() / get_decoder_element() -> gstreamer_v4l2_{encoder,decoder}_for_codec()
get_file_extension() -> gstreamer_container_ext_for_codec() (or similar)
Extract pipeline string creation into library builders:
gstreamer_build_v4l2_encode_pipeline()
gstreamer_build_v4l2_decode_pipeline()
Move bitrate selection + file-size helper into lib (gstreamer_bitrate_for_resolution, gstreamer_file_size_bytes) to avoid re-implementations.

Keep .res emission + summary logic in run.sh. library functions should not write results directly.

Runner/suites/Multimedia/GSTreamer/Display/Waylandsink_Playback/run.sh

Runner/suites/Multimedia/GSTreamer/Display/Waylandsink_Playback/Waylandsink_Playback.yaml

Runner/suites/Multimedia/GSTreamer/Display/Waylandsink_Playback/run.sh

Runner/suites/Multimedia/GSTreamer/Display/Waylandsink_Playback/Waylandsink_Playback.yaml

Runner/suites/Multimedia/GSTreamer/Display/Waylandsink_Playback/run.sh

Runner/suites/Multimedia/GSTreamer/Video/Video_Encode_Decode/run.sh

…r V4L2 video helper functions from Video_Encode_Decode test to shared lib_gstreamer.sh for code reuse across all GStreamer tests Signed-off-by: Nitin Nakka <nitinn@qti.qualcomm.com>

smuppand · 2026-02-15T13:10:14Z

@nitinn22 Kindly close the comments where you've already addressed previous review feedback, so I can focus on the remaining ones. Also, please rebase your work on top of the main branch. Also Updated SPDX license identifiers from BSD-3-Clause-Clear to BSD-3-Clause per legal request.

smuppand

README inconsistency (Waylandsink): help text says default test is “for 10s” but script default duration resolves to 30s. Update README/help examples.

README mismatch (Video): documentation lists encoded outputs like .h264/.h265, but the pipeline uses mp4mux and outputs .mp4. Update README to match reality.

Runner/suites/Multimedia/GSTreamer/Display/Waylandsink_Playback/Waylandsink_Playback.yaml

Runner/suites/Multimedia/GSTreamer/Video/Video_Encode_Decode/run.sh

…video scripts based on review comments Signed-off-by: Nitin Nakka <nitinn@qti.qualcomm.com>

…l request Signed-off-by: Nitin Nakka <nitinn@qti.qualcomm.com>

smuppand · 2026-02-16T11:10:37Z

Runner/suites/Multimedia/GSTreamer/Display/Waylandsink_Playback/run.sh

@@ -0,0 +1,389 @@
+#!/bin/sh
+# Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
+# SPDX-License-Identifier: BSD-3-Clause per legal request. 


Remove per legal request.

smuppand · 2026-02-16T11:11:57Z

Runner/suites/Multimedia/GSTreamer/Display/Waylandsink_Playback/run.sh

+  exit 0
+}
+
+check_dependencies "grep head sed" >/dev/null 2>&1 || {


Both can be combined into a single dependency check.

smuppand · 2026-02-16T11:12:40Z

Runner/suites/Multimedia/GSTreamer/Display/Waylandsink_Playback/run.sh

+
+# -------------------- Pre-checks --------------------
+check_dependencies "gst-launch-1.0 gst-inspect-1.0" >/dev/null 2>&1 || {
+  log_warn "Missing gstreamer runtime (gst-launch-1.0/gst-inspect-1.0)"


Should be log_skip

smuppand · 2026-02-16T11:12:51Z

Runner/suites/Multimedia/GSTreamer/Display/Waylandsink_Playback/run.sh

+}
+
+check_dependencies "grep head sed" >/dev/null 2>&1 || {
+  log_warn "Missing required tools (grep, head, sed)"


Should be log_skip

smuppand · 2026-02-16T11:14:50Z

Runner/suites/Multimedia/GSTreamer/Display/Waylandsink_Playback/run.sh

+      # Parse WIDTHxHEIGHT format (e.g., 1920x1080)
+      if [ -n "$2" ]; then
+        width="${2%%x*}"
+        height="${2#*x}"


No validation that: WIDTHxHEIGHT format is present
both are numeric and height isn’t unchanged when x missing
This can trigger arithmetic/ caps errors later

smuppand · 2026-02-16T11:37:01Z

Runner/suites/Multimedia/GSTreamer/Video/Video_Encode_Decode/run.sh

+
+    for res in $resolutions; do
+      params=$(gstreamer_resolution_to_wh "$res")
+      width=$(printf '%s' "$params" | awk '{print $1}')


Avoid awk and prefer posix clean + faster
set -- $params
width="$1"; height="$2"

smuppand · 2026-02-16T11:42:19Z

Runner/utils/lib_gstreamer.sh

+  res="$1"
+  case "$res" in
+    480p)
+      printf '%s %s\n' "640" "480"


Right now, unknown tokens silently become 480p:

That hides config mistakes (e.g., VIDEO_RESOLUTIONS=4K typo) and makes results misleading.

*)
return 1
;;
Then callers should SKIP that test case (or overall SKIP if no valid resolutions).

smuppand · 2026-02-16T11:44:20Z

Runner/utils/lib_gstreamer.sh

+      ;;
+    vp9)
+      parser=""
+      container="matroskademux"


Then you always go through the container branch, which will generate:

filesrc ! matroskademux ! ! v4l2vp9dec ...
Because parser="", you end up with ! ! (invalid pipeline).

only insert parser when it’s non-empty. Also, VP9 in WebM should be:
filesrc ! matroskademux ! vp9parse ! v4l2vp9dec ... (if vp9parse exists), or
filesrc ! matroskademux ! queue ! v4l2vp9dec ... (often works, but parse is better)

smuppand · 2026-02-16T11:45:39Z

Runner/utils/lib_gstreamer.sh

+  width="$2"
+  height="$3"
+  duration="$4"
+  framerate="$5"


uses $((duration * framerate)) without numeric safety
Library should not assume callers validated this. Any env typo will break pipeline construction.

smuppand · 2026-02-16T11:47:57Z

Runner/utils/lib_gstreamer.sh

+  fi
+
+  # Check for CRITICAL or FATAL level messages
+  if grep -q -E "CRITICAL|FATAL" "$logfile" 2>/dev/null; then


this can match unreleated messages.
prefer anchored or GST_..._ERROR patterns (already partly covered)

grep -q -E '(^CRITICAL:|^FATAL:|gst.*(CRITICAL|FATAL))'

nitinn22 added 2 commits February 13, 2026 18:07

Added Multimedia Video and Display GStreamer test scripts

e08522e

Signed-off-by: Nitin Nakka <nitinn@qti.qualcomm.com>

Fix: make run.sh executables for both video and display scripts

79fd143

Signed-off-by: Nitin Nakka <nitinn@qti.qualcomm.com>

bhargav0610 requested review from smuppand and vnarapar February 13, 2026 13:08

Updated lib gstreamer sh utils file to support logs based post proces…

93f6153

…sing Signed-off-by: Nitin Nakka <nitinn@qti.qualcomm.com>

smuppand requested changes Feb 14, 2026

View reviewed changes

Extract V4L2 video helpers to reusable library. Move generic GStreame…

bd8ef68

…r V4L2 video helper functions from Video_Encode_Decode test to shared lib_gstreamer.sh for code reuse across all GStreamer tests Signed-off-by: Nitin Nakka <nitinn@qti.qualcomm.com>

smuppand requested changes Feb 15, 2026

View reviewed changes

nitinn22 added 2 commits February 15, 2026 23:12

rebased lib_gstreamer.sh and added changes, modified the display and …

55d63f0

…video scripts based on review comments Signed-off-by: Nitin Nakka <nitinn@qti.qualcomm.com>

Added license identifier for all 3 shell files: BSD-3-Clause per lega…

77b5d42

…l request Signed-off-by: Nitin Nakka <nitinn@qti.qualcomm.com>

smuppand requested changes Feb 16, 2026

View reviewed changes

Conversation

nitinn22 commented Feb 13, 2026

Uh oh!

smuppand left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

smuppand commented Feb 15, 2026

Uh oh!

smuppand left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

smuppand left a comment •

edited

Loading