fix(remoteproc): make SSR optional across remoteproc tests to avoid wedge and harden CLI parsing#302
Merged
vnarapar merged 4 commits intoqualcomm-linux:mainfrom Feb 17, 2026
Merged
Conversation
Default to a non-disruptive mode that only validates ADSP presence/boot state, avoiding stop/start sequences that can wedge the audio stack on some boards. - Add --ssr flag to explicitly enable remoteproc stop/start - Keep wait_remoteproc_state polling (timeout + poll interval) for SSR mode - Harden arg parsing for options requiring values to prevent "shift count out of range" - Retain existing logging/results behavior and dmesg/rproc log capture Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
…l interval Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
Default the test to non-destructive mode (no remoteproc stop/start) to avoid triggering SSR-related wedges. Add POSIX-safe argument parsing and expose --ssr plus --stop-to/--start-to/--poll-i overrides, matching adsp_remoteproc behavior. Keep existing DT gating, logging, and result semantics unchanged. Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
Default to non-destructive mode (no remoteproc stop/start) and require --ssr to perform WPSS SSR. Add POSIX-safe argument parsing for --stop-to/--start-to/ --poll-i, and align logging with other remoteproc tests. Keep ath11k fallback path behavior unchanged. Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
smuppand
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the *_remoteproc test to avoid issuing stop/start (SSR) by default, because stopping can wedge the stack (e.g., /proc/asound/pcm hang / D-state tasks) and lead to system deadlocks on some boards. SSR is now opt-in via a CLI flag so we can keep running remoteproc coverage without triggering the known freeze path.
What changed
SSR is optional via --ssr