Fix mypy errors in batch 2 files (#1282)#1357
Open
rosspeili wants to merge 2 commits into
Open
Conversation
Second slice for quantumlib#1282: mechanical typing fixes in seven files. No API changes; no pyproject.toml change. Safer os.cpu_count() handling when it returns None.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces several minor bug fixes, type-safety improvements, and robustness enhancements across the codebase. Key changes include handling None for chemical_potential in mean_field_dwave, refactoring tuple unpacking in prony, adding type-ignore comments to __hash__ overrides, casting a numpy norm to float, and safely calculating MKL_NUM_THREADS to handle cases where os.cpu_count() is None or small. No review comments were provided, so there is no feedback to address.
Contributor
Author
|
Pushed a test to cover the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second slice for #1282: mechanical typing fixes in seven files. No API changes; no pyproject.toml change. Safer os.cpu_count() handling when it returns None.