Skip to content

Fix some stimflow snags#1071

Merged
Strilanc merged 4 commits into
mainfrom
fixhtmlviewer
Jun 8, 2026
Merged

Fix some stimflow snags#1071
Strilanc merged 4 commits into
mainfrom
fixhtmlviewer

Conversation

@Strilanc

@Strilanc Strilanc commented Jun 6, 2026

Copy link
Copy Markdown
Collaborator
  • Escape more characters when setting the crumble URL
  • Add better docstring to stimflow.ChunkBuilder.add_flow
  • Fix the html viewer having extreme height in visual studio code's notebook viewer
    • Default to 500px height and set to 90vh only if javascript determines it is the topmost element in the document

- Escape more characters when setting the crumble URL
- Add better docstring to stimflow.ChunkBuilder.add_flow
- Fix the html viewer having extreme height in visual studio code's notebook viewer
    - Default to 500px height and set to 90vh only if javascript determines it is the topmost element in the document
@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@Strilanc Strilanc enabled auto-merge (squash) June 6, 2026 03:39
@Strilanc Strilanc disabled auto-merge June 6, 2026 04:20
@Strilanc Strilanc enabled auto-merge (squash) June 8, 2026 06:32
@Strilanc Strilanc merged commit 56769dd into main Jun 8, 2026
139 of 156 checks passed
@Strilanc Strilanc deleted the fixhtmlviewer branch June 8, 2026 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant