Update quarto-hub to samod 0.8+ and re-implement document access audit logging#36
Open
shikokuchuo wants to merge 4 commits intomainfrom
Open
Update quarto-hub to samod 0.8+ and re-implement document access audit logging#36shikokuchuo wants to merge 4 commits intomainfrom
shikokuchuo wants to merge 4 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This currently depends on our fork of samod, which implements
AccessPolicyin line with the js reference, with the expectation that this will be upstreamed.We always allow access, only log —
AuditAccessPolicy::should_allow()always returns true. It's used for audit logging, not authorization. Authorization can be layered on later by returning false for denied peers.Summary
AcceptorHandle,dial_websocket, andAccessPolicyAPIsdial_websocketdialer (automatic reconnection with exponential backoff)accept_axum→ handshake_complete → finished pattern to the new event-stream pattern (AcceptorEvent::ClientConnected/ClientDisconnected)AccessPolicytrait, replacing the previousConnectionId-based approach with aPeerId-based one