Skip to content

vex: only check vendor_fix remediations#1904

Merged
github-actions[bot] merged 1 commit into
quay:mainfrom
crozzy:fix-vex-link-bugs
Jun 18, 2026
Merged

vex: only check vendor_fix remediations#1904
github-actions[bot] merged 1 commit into
quay:mainfrom
crozzy:fix-vex-link-bugs

Conversation

@crozzy

@crozzy crozzy commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

RHSA links were being lost for vulnerabilities where the productID had multiple remediations and the last one (without a url was winning). This change modifies populateRemediations to only consider vendor_fix remediations.

@crozzy crozzy requested a review from a team as a code owner June 3, 2026 16:00
@crozzy crozzy requested review from hdonnay and removed request for a team June 3, 2026 16:00
@crozzy crozzy force-pushed the fix-vex-link-bugs branch from 5567934 to 94b0cc3 Compare June 3, 2026 16:50
@crozzy crozzy force-pushed the fix-vex-link-bugs branch 3 times, most recently from 688eb98 to d154645 Compare June 12, 2026 16:52
@crozzy crozzy requested review from BradLugo and dcaravel June 12, 2026 17:24

@dcaravel dcaravel left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding the fragment to links breaks existing deduping logic in stackrox

Keeping the fragment in links would require a stackrox re-work and a v3 vuln bundle to not introduce 'duplicate' vulns into existing deployments.

Given that fragments can appear naturally in URLs, a client may not be able to reliably extract the product ID without making assumptions (ie: product ID is a fragment appended to links for the RH VEX domain+path, which will need to be updated anytime that changes)

Is the placement of the product ID worth a revisit? perhaps a dedicated field or general metadata? Making the product ID available to clients in a relaible way could be a step towards making results explainable.

Comment thread test/acceptance/auditor_claircore.go
RHSA links were being lost for vulnerabilities where the productID had
multiple remediations and the last one (without a `url` was winning).
This change modifies populateRemediations to only consider `vendor_fix`
remediations.

Signed-off-by: crozzy <joseph.crosland@gmail.com>
@crozzy

crozzy commented Jun 17, 2026

Copy link
Copy Markdown
Contributor Author

Adding the fragment to links breaks existing deduping logic in stackrox

Keeping the fragment in links would require a stackrox re-work and a v3 vuln bundle to not introduce 'duplicate' vulns into existing deployments.

Given that fragments can appear naturally in URLs, a client may not be able to reliably extract the product ID without making assumptions (ie: product ID is a fragment appended to links for the RH VEX domain+path, which will need to be updated anytime that changes)

Is the placement of the product ID worth a revisit? perhaps a dedicated field or general metadata? Making the product ID available to clients in a relaible way could be a step towards making results explainable.

@dcaravel I believe this subsequent PR should address these concerns: #1918

@crozzy crozzy force-pushed the fix-vex-link-bugs branch from d154645 to 8c73a7e Compare June 17, 2026 22:47
@crozzy crozzy requested a review from dcaravel June 18, 2026 15:11
@crozzy

crozzy commented Jun 18, 2026

Copy link
Copy Markdown
Contributor Author

/fast-forward

@github-actions

Copy link
Copy Markdown

Triggered from #1904 (comment) by @​crozzy.

Trying to fast forward main (5463b73) to fix-vex-link-bugs (8c73a7e).

Target branch (main):

commit 5463b737ba7fa9c02a56b503e0306fbd0132fc55 (HEAD -> main, origin/main)
Author: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Date:   Fri Jun 12 18:15:08 2026 +0000

    chore(deps): bump the golang-x group across 1 directory with 2 updates
    
    Bumps the golang-x group with 2 updates in the / directory: [golang.org/x/net](https://github.com/golang/net) and [golang.org/x/tools](https://github.com/golang/tools).
    
    
    Updates `golang.org/x/net` from 0.55.0 to 0.56.0
    - [Commits](https://github.com/golang/net/compare/v0.55.0...v0.56.0)
    
    Updates `golang.org/x/tools` from 0.45.0 to 0.46.0
    - [Release notes](https://github.com/golang/tools/releases)
    - [Commits](https://github.com/golang/tools/compare/v0.45.0...v0.46.0)
    
    ---
    updated-dependencies:
    - dependency-name: golang.org/x/net
      dependency-version: 0.56.0
      dependency-type: direct:production
      update-type: version-update:semver-minor
      dependency-group: golang-x
    - dependency-name: golang.org/x/tools
      dependency-version: 0.46.0
      dependency-type: direct:production
      update-type: version-update:semver-minor
      dependency-group: golang-x
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>

Pull request (fix-vex-link-bugs):

commit 8c73a7e20d31c1eb5293a0e3fc8344b176e6172b (pull_request/fix-vex-link-bugs)
Author: Joseph Crosland <jcroslan@redhat.com>
Date:   Wed Jun 3 08:40:27 2026 -0700

    vex: only check vendor_fix remediations
    
    RHSA links were being lost for vulnerabilities where the productID had
    multiple remediations and the last one (without a `url` was winning).
    This change modifies populateRemediations to only consider `vendor_fix`
    remediations.
    
    Signed-off-by: crozzy <joseph.crosland@gmail.com>

Fast forwarding main (5463b73) to fix-vex-link-bugs (8c73a7e).

$ git push origin 8c73a7e20d31c1eb5293a0e3fc8344b176e6172b:main
remote: error: GH013: Repository rule violations found for refs/heads/main.        
remote: Review all repository rules at https://github.com/quay/claircore/rules?ref=refs%2Fheads%2Fmain        
remote: 
remote: - Waiting on code owner review from quay/clair.        
remote: 
To https://github.com/quay/claircore.git
 ! [remote rejected]   8c73a7e20d31c1eb5293a0e3fc8344b176e6172b -> main (push declined due to repository rule violations)
error: failed to push some refs to 'https://github.com/quay/claircore.git'

@crozzy

crozzy commented Jun 18, 2026

Copy link
Copy Markdown
Contributor Author

/fast-forward

@github-actions

Copy link
Copy Markdown

Triggered from #1904 (comment) by @​crozzy.

Trying to fast forward main (5463b73) to fix-vex-link-bugs (8c73a7e).

Target branch (main):

commit 5463b737ba7fa9c02a56b503e0306fbd0132fc55 (HEAD -> main, origin/main)
Author: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Date:   Fri Jun 12 18:15:08 2026 +0000

    chore(deps): bump the golang-x group across 1 directory with 2 updates
    
    Bumps the golang-x group with 2 updates in the / directory: [golang.org/x/net](https://github.com/golang/net) and [golang.org/x/tools](https://github.com/golang/tools).
    
    
    Updates `golang.org/x/net` from 0.55.0 to 0.56.0
    - [Commits](https://github.com/golang/net/compare/v0.55.0...v0.56.0)
    
    Updates `golang.org/x/tools` from 0.45.0 to 0.46.0
    - [Release notes](https://github.com/golang/tools/releases)
    - [Commits](https://github.com/golang/tools/compare/v0.45.0...v0.46.0)
    
    ---
    updated-dependencies:
    - dependency-name: golang.org/x/net
      dependency-version: 0.56.0
      dependency-type: direct:production
      update-type: version-update:semver-minor
      dependency-group: golang-x
    - dependency-name: golang.org/x/tools
      dependency-version: 0.46.0
      dependency-type: direct:production
      update-type: version-update:semver-minor
      dependency-group: golang-x
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>

Pull request (fix-vex-link-bugs):

commit 8c73a7e20d31c1eb5293a0e3fc8344b176e6172b (pull_request/fix-vex-link-bugs)
Author: Joseph Crosland <jcroslan@redhat.com>
Date:   Wed Jun 3 08:40:27 2026 -0700

    vex: only check vendor_fix remediations
    
    RHSA links were being lost for vulnerabilities where the productID had
    multiple remediations and the last one (without a `url` was winning).
    This change modifies populateRemediations to only consider `vendor_fix`
    remediations.
    
    Signed-off-by: crozzy <joseph.crosland@gmail.com>

Fast forwarding main (5463b73) to fix-vex-link-bugs (8c73a7e).

$ git push origin 8c73a7e20d31c1eb5293a0e3fc8344b176e6172b:main
remote: error: GH013: Repository rule violations found for refs/heads/main.        
remote: Review all repository rules at https://github.com/quay/claircore/rules?ref=refs%2Fheads%2Fmain        
remote: 
remote: - Waiting on code owner review from quay/clair.        
remote: 
To https://github.com/quay/claircore.git
 ! [remote rejected]   8c73a7e20d31c1eb5293a0e3fc8344b176e6172b -> main (push declined due to repository rule violations)
error: failed to push some refs to 'https://github.com/quay/claircore.git'

@vulerh vulerh requested review from vulerh and removed request for hdonnay and vulerh June 18, 2026 19:52
@crozzy crozzy requested a review from vulerh June 18, 2026 19:57

@vulerh vulerh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! thanks

@crozzy

crozzy commented Jun 18, 2026

Copy link
Copy Markdown
Contributor Author

/fast-forward

@github-actions github-actions Bot merged commit 8c73a7e into quay:main Jun 18, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants