acceptance: add VEX parser option to include the productID#1922
Open
crozzy wants to merge 1 commit into
Open
Conversation
The VEX productID is useful for testing but can cause issues when included in production. This adds the parser option to be able to turn on adding the productID to the VEX file link for use during testing. Signed-off-by: crozzy <joseph.crosland@gmail.com>
crozzy
force-pushed
the
acceptance-optional-productID-fragment2
branch
from
6bd0766 to
d88e076
Compare
dcaravel
approved these changes
Jun 18, 2026
dcaravel
left a comment
dcaravel
left a comment
There was a problem hiding this comment.
LGTM
nit: consider adding a unit test to parser_test.go for when the option is enabled.
Contributor
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The VEX productID is useful for testing but can cause issues when included in production. This adds the parser option to be able to turn on adding the productID to the VEX file link for use during testing.