Refactor SessionSchedule to use java.time classes#1225
Draft
Copilot wants to merge 8 commits into
Draft
Conversation
Agent-Logs-Url: https://github.com/quickfix-j/quickfixj/sessions/ef6ae2c0-e37a-470b-844b-0b3669bf49e0 Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>
Agent-Logs-Url: https://github.com/quickfix-j/quickfixj/sessions/ef6ae2c0-e37a-470b-844b-0b3669bf49e0 Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>
Agent-Logs-Url: https://github.com/quickfix-j/quickfixj/sessions/fd599c00-e171-4397-ba2a-55d22de77d69 Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>
Agent-Logs-Url: https://github.com/quickfix-j/quickfixj/sessions/ac53da8d-957c-49ef-82c3-1e528a9fc119 Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>
…sion Agent-Logs-Url: https://github.com/quickfix-j/quickfixj/sessions/86d191b3-7848-4e01-9557-1c6bc19cb837 Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>
Agent-Logs-Url: https://github.com/quickfix-j/quickfixj/sessions/d264a768-54d3-4d1c-aa57-93785bc1f619 Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
chrjohn
May 16, 2026 19:24
View session
Member
|
@copilot LogUtilTest.testLogThrowable:51 fails |
Agent-Logs-Url: https://github.com/quickfix-j/quickfixj/sessions/6e680b34-2576-43e6-8a75-bcadbffdd3df Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>
Contributor
Author
SessionScheduleTest coverage for previous-day start-of-week handlingSessionSchedule to use java.time classes
Member
|
Hi @alexwibowo , any news regarding #1147 ? Could you take a look at this PR? I copied your failing test also to this branch and it seems to work... i need to do a final review though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
quickfixj-core/src/main/java/quickfix/DefaultSessionSchedule.javafromCalendar/SimpleDateFormatinternals tojava.time(Instant,ZonedDateTime,DateTimeFormatter) and epoch-millisTimeIntervalboundaries.DefaultSessionScheduleto useWeekFields.SUNDAY_START, including previous-day/week rollover handling.SessionScheduleAPI inquickfixj-core/src/main/java/quickfix/SessionSchedule.javato useisSameSession(long, long)plus aZonedDateTimedefault bridge method.quickfixj-core/src/main/java/quickfix/Session.javato call the long-based schedule API using session creation time millis.quickfixj-core/src/main/java/quickfix/NoopStore.javacreation-time handling to useSystemTime.currentTimeMillis()/Instant, and to derive calendar values on demand.quickfixj-core/src/test/java/quickfix/SessionScheduleTest.java, includingtestSessionStartInPreviousDayOfWeek()andZonedDateTime-basedisSameSessionassertions.quickfixj-core/src/test/java/quickfix/DefaultSessionScheduleTest.javacoverage for stable UTCtoString()formatting.quickfixj-core/src/test/java/quickfix/LogUtilTest.javaso the store stub throws fromgetCreationTime()(matching the updated session path).SessionScheduleTestandLogUtilTestafter the changes.