Open
Conversation
Additionally fixed some error messages acording to current message in Rails 7.1+ "undefined method 'permit' for.."
3 tasks
Fixes include removing two legacy explicit requires and update spec assertions to match changed Rails 8 error messages.
Nothing to migrate to Solid Cable since it is entirely unused therefore only cleanup.
Only setting up as there are no jobs at the moment in etengine.
Replaces Memcache(Dalli)
3 tasks
3 tasks
noracato
reviewed
Mar 19, 2026
|
|
||
| development: | ||
| <<: *default | ||
|
|
Member
There was a problem hiding this comment.
Do we need a staging entry here?
| threads: 3 | ||
| processes: <%= ENV.fetch("JOB_CONCURRENCY", 1) %> | ||
| polling_interval: 0.1 | ||
|
|
Member
There was a problem hiding this comment.
Same here: do we need a staging entry?
Comment on lines
+1
to
+10
| # examples: | ||
| # periodic_cleanup: | ||
| # class: CleanSoftDeletedRecordsJob | ||
| # queue: background | ||
| # args: [ 1000, { batch_size: 500 } ] | ||
| # schedule: every hour | ||
| # periodic_cleanup_with_command: | ||
| # command: "SoftDeletedRecord.due.delete_all" | ||
| # priority: 2 | ||
| # schedule: at 5am every day |
Member
There was a problem hiding this comment.
As a note: we can use this to clean up old mechanical turk scenarios from the db, instead of using cron jobs via ansible. This also makes our data policies more clear to our users.
| ruby 3.4.7p58 | ||
|
|
||
| BUNDLED WITH | ||
| 2.6.6 |
Member
There was a problem hiding this comment.
Bundle version got downgraded. Bundler 4 just came out. We should use that for Ruby 4.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
With the goal to update Ruby/Rails stack apps to Ruby 4 and Rails 8 (etengine, etmodel, etlocal, my-etm).
Now we are making a in-between step to Ruby 3.4 to be able to run respec with deprecation warnings.
Then finally update to Rails 8.1, fix any issues and adopt the Solid Stack where relevant.
Implemented changes
Note that some configuration is necessary, we added dedicated DBs for Solid Queue and Solid Cache, that needs configuring some env vars:
Related
This is one of 5 PRs with the same purpose across the following 4 repos:
Checklist