Skip to content

Emissions 1990#1760

Open
louispt1 wants to merge 54 commits into
emissionsfrom
emissions-1990
Open

Emissions 1990#1760
louispt1 wants to merge 54 commits into
emissionsfrom
emissions-1990

Conversation

@louispt1

@louispt1 louispt1 commented Jun 8, 2026 •
edited by kndehaan
Loading

Copy link
Copy Markdown
Member

Context

Adds multi-year emissions support with 1990 baseline tracking and aggregation capabilities.

Implemented changes

  • Added year column to emissions CSV schema
  • Implemented Qernel::Emissions#sum() for subsector aggregation
  • Updated EMISSIONS() GQL function to aggregate across subsectors
  • Enhanced ScopedSector with year-aware scoping
  • Updated atlas gem dependency (includes emissions schema changes)

Related

Goes with pull requests:

Checklist

  • I have tested these changes
  • I have updated documentation as needed
  • I have tagged the relevant people for review

louispt1 and others added 30 commits June 1, 2026 09:38
@louispt1
Implement A, C and E: input and output without capture, & CO2 product…
362d87e 
…ion methods
@louispt1
Add guard based on the emissions group
f2a177e
@louispt1
Apply recursive edge logic to output and input edges for direct emiss…
c67eb36 
…ions
@louispt1
Dataset EMISSIONS method implementation
89faeb0
@louispt1
Add emissions methods for molecule nodes
9e360b8
@louispt1
Improve crude oil tests and recursion through multiple levels
21b7191
@louispt1
Optimise direct emissions checks using memoization of the group check…
4fe9433 
… and create boutique DE RF module to keep edge cases in one spot
@louispt1
remove memoization from the edge group check as this was causing circ…
abe362c 
…ular references for Marshall
@louispt1
Correction to emissions method
81dc529
@louispt1
Handle split LULUCF in molecule emissions
66702de
@louispt1
Biogenic input output and production methods for direct emissions
5d9b9a3
@louispt1
Direct emissions utilisation and tests
f1ef35e
@kndehaan @louispt1
Update attributes.rb with co2_utilisation_per_mj
829f77d
@louispt1
Refactor direct emissions, introduce capture methods, correct direct_…
de044fa 
…co2_output_production_emissions_fossil and spec
@louispt1
Update existing engine methods to account for captured CO2
f8b9bc8
@louispt1
Update bio-emissions to use free_co2_factor, depending on the prescen…
5a3a89c 
…ce of ccs_capture_rate. Update spec
@louispt1
Update methods based on excel formulas
87d6111
@louispt1
Adjust comments, add TODOs and remove direct_co2_input_utilisation me…
6eb705c 
…thod as direct_co2_input_utilisation_fossil is sufficient
@louispt1
Implement emissions method for CO2 capture on molecule nodes
60cb93e
@louispt1
Handle co2_per_mj check when recursing for bio emissions, remove ccus…
b8db250 
…_utilised and emissions_lulucf_removals checks from spec
@louispt1
Update atlas reference to explicit commit hash
004e85b
@louispt1
Removed scoped accessor in favour of hash - can re-instate accessor i…
1cab4bb 
…f required
@louispt1
return ccus_captured to eager memoization to match other methods and …
3bc39a3 
…now it covers more cases
@louispt1
Resolve biogenic recursion issue and return to lazy memoization for c…
292b8fb 
…cus_captured?
@kndehaan @louispt1
Node colour for Waste and LULUCF sectors
4d7ddf7
@louispt1
Fix for biogenic output
ea575bb
@louispt1
Add node level check for biogenic CO2, simplify direct emissions outp…
ed4f5d4 
…ut co2 content approach
@louispt1
Clean up comments for PR
67a0ef4
@louispt1
Update atlas reference to latest commit hash
94c8174
@louispt1
Replace ABCDE references with worded fomulas in direct emissions comm…
2d89c74 
…ents
@louispt1 louispt1 requested a review from kndehaan June 8, 2026 13:20
@louispt1 louispt1 mentioned this pull request Jun 8, 2026
Open
3 tasks
@noracato
Emission validation (#1759)
dfb21c4 
* Add a validation lib spec for node values per dataset

* Add dev and test modes for graph data validation
@kndehaan kndehaan requested a review from noracato June 10, 2026 06:43
@kndehaan

kndehaan commented Jun 10, 2026

Copy link
Copy Markdown
Member

The summing works well now! I added @noracato as reviewer to review the code.

louispt1 added 14 commits June 16, 2026 14:42
@louispt1
Bump atlas commit
2f1c07a
@louispt1
Implement EMISSIONS_MAP lookup and tests EMISSIONS_MAP('1.A.4.a') -->…
a904779 
… [<Node>, <Node>, ...]
@louispt1
Handle sum to aggregate sectors based on prefixes, and hangle year em…
eb5e26d 
…issions format
@louispt1
Remove the crt mapping logic for now
59825d9
@louispt1
Refine permissiveness of getters + setters for qernel::emissions
4ce27d5
@louispt1
Minor improvements
9e7e4e8
@louispt1
Workaround for non_energetic vs energetic use in the sum function
2077665
@louispt1
Make regex lookbehind more explicit
aef38d6
@louispt1
builds a structured emissions_index alongside the flat value hash to …
d077a9a 
…preserve column boundaries whic are lost when normalising keys
@louispt1
Add reporting methods for CO2 utilisation and biogenic emissions & spec
7a9220b
@louispt1
Swap arguments for reporting methods for CO2 utilisation and biogenic…
84ce1ff 
… emissions
@louispt1
Simplify 1990 changes
9cd6616
@louispt1
Add reporting methods to molecule nodes that return 0.0 (and spec)
98d2ac2
@louispt1
Improve spec and cover missing methods
3292dd1
This was referenced Jun 18, 2026
Draft
Draft
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kndehaan kndehaan kndehaan approved these changes

@noracato noracato Awaiting requested review from noracato

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@louispt1 @kndehaan @aaccensi @noracato