Add a spec that checks for crude oil exceptions#3446
Closed
mabijkerk wants to merge 2 commits into
Closed
Conversation
3 tasks
Member
|
Internally discussed that the work of this spec would still require dev effort in reviewing and modifying. As the crude oil exception is a temporary solution I don't think it's the effort to spend too much additional time on this spec. Therefore closing this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
In the new emissions accounting method added in #3444 we add an edge exception case for crude oil mix.
Implemented changes
I had AI write a spec that validates whether all relevant crude oil edges downstream of a final demand mixing node carry the exception group (to prevent missing edges) and that checks it the other way around (to prevent adding irrelevant edges).
I explitictly instructed it to use the Atlas graph builder.
Checklist