Skip to content

Conversation

@rabbitstack
Copy link
Owner

What is the purpose of this PR / why it is needed?

This PR brings various changes to the isolate action. The first of them is declaring the WFP session as dynamic, Dynamic sessions are meant to add firewall configuration that should not outlast the program's execution. The second fix prevents the deadlock on mutex when adding whitelist IP addresses. Lastly, The current limitation of the fw library, makes it impossible to install a filter with multiple IP addresses, so we shrink the list to always append the first IP address in the list.

What type of change does this PR introduce?


Uncomment one or more /kind <> lines:

/kind feature (non-breaking change which adds functionality)

/kind bug-fix (non-breaking change which fixes an issue)

/kind refactor (non-breaking change that restructures the code, while not changing the original functionality)

/kind breaking (fix or feature that would cause existing functionality to not work as expected

/kind cleanup

/kind improvement

/kind design

/kind documentation

/kind other (change that doesn't pertain to any of the above categories)

Any specific area of the project related to this PR?


Uncomment one or more /area <> lines:

/area instrumentation

/area telemetry

/area rule-engine

/area filters

/area yara

/area event

/area captures

/area alertsenders

/area outputs

/area rules

/area filaments

/area config

/area cli

/area tests

/area ci

/area build

/area docs

/area deps

/area other

Special notes for the reviewer


Does this PR introduce a user-facing change?


Dynamic sessions are meant for adding firewall configuration that should not outlast program's execution.
The current limitation of the fw library, makes it impossible to install a filter with multiple IP
addresses, so we shrink the list to always append
the first IP address in the list.
@rabbitstack rabbitstack merged commit 1b6c87e into master Mar 13, 2025
9 checks passed
@rabbitstack rabbitstack deleted the fix-isolate-action branch March 13, 2025 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants