Skip to content

fix(tests): Try to stabilize flaky tests #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rabbitstack merged 1 commit into from
Oct 13, 2025
Merged

fix(tests): Try to stabilize flaky tests #536

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 14 additions & 35 deletions internal/etw/source_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,18 @@ package etw
import (
"context"
"fmt"
"net"
"net/http"
"os"
"os/exec"
"path/filepath"
"runtime"
"strings"
"syscall"
"testing"
"time"
"unsafe"

"github.com/rabbitstack/fibratus/internal/evasion"
"github.com/rabbitstack/fibratus/pkg/config"
"github.com/rabbitstack/fibratus/pkg/event"
Expand All @@ -39,17 +51,6 @@ import (
"github.com/stretchr/testify/require"
"golang.org/x/sys/windows"
"golang.org/x/sys/windows/registry"
"net"
"net/http"
"os"
"os/exec"
"path/filepath"
"runtime"
"strings"
"syscall"
"testing"
"time"
"unsafe"
)

// MockListener receives the event and does nothing but indicating the event was processed.
Expand Down Expand Up @@ -626,30 +627,8 @@ func TestEventSourceAllEvents(t *testing.T) {
{
"duplicate handle",
func() error {
var si windows.StartupInfo
var pi windows.ProcessInformation
argv, err := windows.UTF16PtrFromString(filepath.Join(os.Getenv("windir"), "notepad.exe"))
if err != nil {
return err
}
err = windows.CreateProcess(
nil,
argv,
nil,
nil,
true,
0,
nil,
nil,
&si,
&pi)
if err != nil {
return err
}
time.Sleep(time.Second)
defer windows.TerminateProcess(pi.Process, 0)
hs := handle.NewSnapshotter(&config.Config{EnumerateHandles: true}, nil)
handles, err := hs.FindHandles(pi.ProcessId)
handles, err := hs.FindHandles(uint32(os.Getppid()))
if err != nil {
return err
}
Expand All @@ -660,7 +639,7 @@ func TestEventSourceAllEvents(t *testing.T) {
}
}
assert.False(t, dupHandleID == 0)
dup, err := handle.Duplicate(dupHandleID, pi.ProcessId, windows.KEY_READ)
dup, err := handle.Duplicate(dupHandleID, uint32(os.Getppid()), 0)
if err != nil {
return err
}
Expand Down
7 changes: 4 additions & 3 deletions pkg/pe/parser_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,13 @@
package pe

import (
"github.com/stretchr/testify/require"
"golang.org/x/sys/windows"
"os"
"path/filepath"
"testing"
"time"

"github.com/stretchr/testify/require"
"golang.org/x/sys/windows"
)

func TestParseFile(t *testing.T) {
Expand Down Expand Up @@ -106,7 +107,7 @@ func TestParseMem(t *testing.T) {
executable string
expectedSections int
}{
{filepath.Join(os.Getenv("windir"), "notepad.exe"), 7},
{filepath.Join(os.Getenv("windir"), "regedit.exe"), 8},
}

for _, tt := range tests {
Expand Down
Loading