fix(rule_engine): Permit sequence link sets #543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Events can end up decorated with more than one sequence value. For example, a freshly created process can be assigned the ps.uuid or ps.name join field, and the rule engine would effectively override the last matched event. For this reason, it is necessary to allow sequence value sets, so that sequence matching can consider multiple values extracted from the join field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this PR / why it is needed?
Events can end up decorated with more than one sequence value. For example, a freshly created process can be assigned the
ps.uuidorps.namejoin field, and the rule engine would effectively override the last matched event. For this reason, it is necessary to allow sequence value sets so that that sequence matching can consider multiple values extracted from the join field.What type of change does this PR introduce?
/kind bug-fix (non-breaking change which fixes an issue)
Any specific area of the project related to this PR?
/area rule-engine
Special notes for the reviewer
Does this PR introduce a user-facing change?