Skip to content

perf(rule_engine,filter): Improve bound sequences #545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rabbitstack merged 1 commit into from
Jan 6, 2026
Merged

perf(rule_engine,filter): Improve bound sequences #545

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pkg/filter/accessor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ func (*evtAccessor) Get(f Field, evt *event.Event) (params.Value, error) {
// referenced in the bound field.
func (f *filter) narrowAccessors() {
var (
removeKevtAccessor = true
removeEvtAccessor = true
removePsAccessor = true
removeThreadAccessor = true
removeImageAccessor = true
Expand All @@ -169,8 +169,8 @@ func (f *filter) narrowAccessors() {

for _, field := range f.fields {
switch {
case field.Name.IsKevtField():
removeKevtAccessor = false
case field.Name.IsKevtField(), field.Name.IsEvtField():
removeEvtAccessor = false
case field.Name.IsPsField():
removePsAccessor = false
case field.Name.IsThreadField():
Expand All @@ -196,7 +196,7 @@ func (f *filter) narrowAccessors() {
}
}

if removeKevtAccessor {
if removeEvtAccessor {
f.removeAccessor(&evtAccessor{})
}
if removePsAccessor {
Expand Down
3 changes: 2 additions & 1 deletion pkg/filter/fields/fields_windows.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -563,7 +563,8 @@ func (f Field) String() string { return string(f) }
func (f Field) Type() params.Type { return fields[f].Type }

func (f Field) IsPsField() bool { return strings.HasPrefix(string(f), "ps.") }
func (f Field) IsKevtField() bool { return strings.HasPrefix(string(f), "evt.") }
func (f Field) IsKevtField() bool { return strings.HasPrefix(string(f), "kevt.") }
func (f Field) IsEvtField() bool { return strings.HasPrefix(string(f), "evt.") }
func (f Field) IsThreadField() bool { return strings.HasPrefix(string(f), "thread.") }
func (f Field) IsImageField() bool { return strings.HasPrefix(string(f), "image.") }
func (f Field) IsFileField() bool { return strings.HasPrefix(string(f), "file.") }
Expand Down
Loading
Loading