Skip to content

perf(rule_engine,filter): Preallocate default accessor values #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rabbitstack merged 1 commit into from
Jan 5, 2026
Merged

perf(rule_engine,filter): Preallocate default accessor values #548

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions pkg/filter/accessor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,13 @@ func (f *filter) removeAccessor(removed Accessor) {
}
}

var (
zeroTime time.Time
zeroSlice []string
zeroIP net.IP
zeroByte []byte
)

// defaultAccessorValue provides the default value for the field.
// This value is typically assigned when the accessor returns an
// error or nil value, but the map valuer must contain the resolved
Expand All @@ -260,15 +267,15 @@ func defaultAccessorValue(field Field) any {
case params.Float, params.Double:
return 0.0
case params.Time:
return time.Now()
return zeroTime
case params.Bool:
return false
case params.IP, params.IPv4, params.IPv6:
return net.IP{}
return zeroIP
case params.Binary:
return []byte{}
return zeroByte
case params.Slice:
return []string{}
return zeroSlice
default:
return ""
}
Expand Down
Loading