Skip to content

Conversation

@santib
Copy link
Collaborator

@santib santib commented Dec 26, 2025

CI started failing since connection_pool 3 was released https://github.com/rack/rack-attack/actions/runs/20482828723

It's an indirect dependency, but our dependencies weren't prepared for these breaking changes on connection_pool

@santib santib requested a review from grzuy December 26, 2025 13:09
@grzuy grzuy changed the title Fix CI: connection_pool version ci: connection_pool version Dec 27, 2025
Copy link
Collaborator

@grzuy grzuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 💯

@grzuy grzuy changed the title ci: connection_pool version ci: test against a compatible connection_pool version Dec 27, 2025
@santib santib force-pushed the fix-ci-connection-pool branch 3 times, most recently from b8d489f to b9cfa6a Compare December 29, 2025 17:22
@santib santib force-pushed the fix-ci-connection-pool branch from b9cfa6a to 217c129 Compare December 29, 2025 17:33
@grzuy grzuy enabled auto-merge (squash) December 30, 2025 01:01
@santib santib force-pushed the fix-ci-connection-pool branch from a9294ee to 2b828af Compare December 30, 2025 12:56
@grzuy grzuy merged commit 1155c26 into rack:main Dec 30, 2025
78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants