Draft
Conversation
capfredf
force-pushed
the
fix-prop-evt
branch
2 times, most recently
from
b452903 to
f5c0ca1
Compare
capfredf
commented
Apr 21, 2022
capfredf
commented
Apr 21, 2022
capfredf
commented
Apr 21, 2022
capfredf
commented
Apr 21, 2022
capfredf
commented
Apr 21, 2022
capfredf
commented
Apr 27, 2022
|
|
||
| (ann (sync (aaa1 ch)) Number) | ||
|
|
||
| (struct aaa2 ([evt : (Channelof Number)]) |
Member
Author
There was a problem hiding this comment.
tests for cases where 1. the designated field type is not an event type 2. the lambda returns a non-event
capfredf
commented
Apr 27, 2022
| "expected: a function that takes only one argument")) | ||
| (if (subtype rng-t (-evt Univ)) | ||
| rng-t | ||
| ;; if the return type is not an event, we make an event type using the structure type |
Member
Author
There was a problem hiding this comment.
what about polymorphic structures? tests?
samth
reviewed
Sep 9, 2022
Member
samth
left a comment
samth
left a comment
There was a problem hiding this comment.
Do we need to address more of the things in the top comment before moving forward here?
Member
Author
|
I feel like my planned ad-hoc fixes/hacks would work, but I am planning to take a look at type families and see if I get some inspiration so we can solve this problem at a higher level. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prop:procedureandprop:evtat the same timecloses #167
The basic idea is 1. we should check
prop:evtin the similar way as we checkprop:procedure, and also we handle their differences correctly via a table + high order functions2. so the structure type rep should store a list of extra types extracted from values for those properties.