Support library modules with AGP9 new DSL#1905
Open
fabiomachuca-w wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Android 9 pull request only fixes AGP 9 with new DSL enabled for application modules, but library modules still fail since they do not have an
ApplicationExtension.This pull request reverts some of the changes from the original pull request and updates it to work with all types of Android Gradle modules. The rationale for the changes:
AndroidComponentsExtensionis supported by all the Android Gradle Plugin versions supported by Byte Buddy, as it already existed in version 7.2.CommonExtensionis supported all the way back to 7.2 and all the way up to 9.1, and works with the new DSL disabled or enabled.Verified the following projects build successfully with these changes: