Skip to content

fix: use regular font size for table cells#104

Merged
rsbh merged 1 commit into
mainfrom
fix/table-cell-font
May 22, 2026
Merged

fix: use regular font size for table cells#104
rsbh merged 1 commit into
mainfrom
fix/table-cell-font

Conversation

@rsbh
Copy link
Copy Markdown
Member

@rsbh rsbh commented May 22, 2026

Summary

  • Override Apsara's small font-size (12px) on th and regular on td
  • Both td and th now use --rs-font-size-regular (14px)
  • th uses --rs-font-weight-medium for bold headers
  • Applied to both default and paper themes

Test plan

  • Table cell text matches content font size
  • Table headers are bold
  • Both themes consistent

Generated with Claude Code

Override Apsara's small font-size on td and th.
Both themes now use --rs-font-size-regular with medium weight on th.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented May 22, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
chronicle Ready Ready Preview, Comment May 22, 2026 7:50am

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 22, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 813b5104-4ef1-4559-b90d-655d4ddf5ab4

📥 Commits

Reviewing files that changed from the base of the PR and between 59076ad and 17c20d5.

📒 Files selected for processing (2)
  • packages/chronicle/src/themes/default/Page.module.css
  • packages/chronicle/src/themes/paper/Page.module.css

📝 Walkthrough

Summary by CodeRabbit

Style

  • Enhanced table cell and header styling across themes with explicit font sizing for improved consistency.
  • Updated table header weight styling to strengthen visual hierarchy within page content.

Walkthrough

This PR adds explicit font-size and font-weight styling rules to table cells in the content area across the default and paper theme variants. Both theme modules now standardize table text rendering by setting font sizes for data and header cells, with header cells also receiving explicit font-weight styling.

Changes

Theme table cell styling

Layer / File(s) Summary
Table cell styling in default and paper themes
packages/chronicle/src/themes/default/Page.module.css, packages/chronicle/src/themes/paper/Page.module.css
Added explicit font-size styling for .content table td and .content table th selectors in both theme variants. Default theme also sets font-weight for table header cells to ensure consistent typography across theme options.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • raystack/chronicle#96: Both PRs modify table-related CSS in packages/chronicle/src/themes/*/Page.module.css, with this PR adding font-size/weight rules for table cells and PR #96 addressing related table layout and wrapping changes.

Suggested reviewers

  • rohanchkrabrty
  • paanSinghCoder
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: fixing table cell font sizes to use regular size instead of smaller sizes.
Description check ✅ Passed The description is directly related to the changeset, providing specific details about font-size overrides, design tokens used, and the themes affected by the changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/table-cell-font

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rsbh rsbh merged commit f2a6ea5 into main May 22, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants