feat(admin-ui): unify page header height and surface icon prop on Views#1606
feat(admin-ui): unify page header height and surface icon prop on Views#1606paanSinghCoder wants to merge 5 commits into
Conversation
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Coverage Report for CI Build 26026326405Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Coverage decreased (-0.02%) to 42.291%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions560 previously-covered lines in 12 files lost coverage.
Coverage Stats
💛 - Coveralls |
rohanchkrabrty
left a comment
There was a problem hiding this comment.
IMO we can create a BaseViewProps and then extend all view/extend types from it
…nent across plans, roles, and webhooks views
@rohanchkrabrty There is only one prop (icon) shared across these components. I don't think creating a base type adds much value here. |
…ith PageHeader in products views
…feat/admin-page-header-icon-and-height
…environment variable in Dockerfile.dev
Two small follow-ups to the Apsara v1 migration:
1. Header height parity
2. Icon prop on Views
Base
Targets `chore/sdk-admin-apsara-v1` (the migration PR). Auto-retargets to `main` once that merges.