Skip to content

[Actions] Redesign the Windows build to automatically find the proper devenv#339

Merged
VeithMetro merged 1 commit into
masterfrom
development/actions-windows
Jun 11, 2026
Merged

[Actions] Redesign the Windows build to automatically find the proper devenv#339
VeithMetro merged 1 commit into
masterfrom
development/actions-windows

Conversation

@VeithMetro

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings June 10, 2026 07:56

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Windows GitHub Actions workflow to locate Visual Studio’s devenv dynamically at runtime instead of relying on a hard-coded path, improving portability across runner images/VS editions.

Changes:

  • Removed the hard-coded devEnv path from workflow env.
  • Added a vswhere-based discovery step to determine the Visual Studio install path and derive devenv.
  • Simplified repeated per-project build commands into a for loop to reduce duplication.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/Build ThunderClientLibraries on Windows.yml
@VeithMetro VeithMetro requested a review from sebaszm June 11, 2026 06:36
@VeithMetro VeithMetro merged commit cc2deb7 into master Jun 11, 2026
48 checks passed
@VeithMetro VeithMetro deleted the development/actions-windows branch June 11, 2026 06:52
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants