-
Notifications
You must be signed in to change notification settings - Fork 141
fix: panel styles and classNames not working #409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
keiseiTi
wants to merge
4
commits into
react-component:master
Choose a base branch
from
keiseiTi:fix/classNamesAndStyle
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+97
−4
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
a9aba53
fix: panel styles and classNames not working
keiseiTi ecd38af
fix: adjust classNames and styles in the Panel
keiseiTi a5d71b7
fix: merge classNames and styles in the panel, and add test
keiseiTi d57c865
fix: adjust test and merged styles and classNames
keiseiTi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,8 @@ | ||
| import toArray from '@rc-component/util/lib/Children/toArray'; | ||
| import React from 'react'; | ||
| import type { CollapsePanelProps, CollapseProps, ItemType } from '../interface'; | ||
| import type { CollapsePanelProps, CollapseProps, ItemType, SemanticName } from '../interface'; | ||
| import CollapsePanel from '../Panel'; | ||
| import clsx from 'clsx'; | ||
|
|
||
| type Props = Pick< | ||
| CollapsePanelProps, | ||
|
|
@@ -22,7 +23,7 @@ const convertItemsToNodes = (items: ItemType[], props: Props) => { | |
| openMotion, | ||
| expandIcon, | ||
| classNames: collapseClassNames, | ||
| styles, | ||
| styles: collapseStyles, | ||
| } = props; | ||
|
|
||
| return items.map((item, index) => { | ||
|
|
@@ -33,6 +34,8 @@ const convertItemsToNodes = (items: ItemType[], props: Props) => { | |
| collapsible: rawCollapsible, | ||
| onItemClick: rawOnItemClick, | ||
| destroyOnHidden: rawDestroyOnHidden, | ||
| classNames, | ||
| styles, | ||
| ...restProps | ||
| } = item; | ||
|
|
||
|
|
@@ -57,11 +60,39 @@ const convertItemsToNodes = (items: ItemType[], props: Props) => { | |
| isActive = activeKey.indexOf(key) > -1; | ||
| } | ||
|
|
||
| const mergeClassNames: Partial<Record<SemanticName, string>> = { | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 我建议是在 Collapse 顶层做一个 SemanticContext,然后传入 classNames 和 styles,然后在 panel 里读取 className 和 style 以及 contextClassName 和 contextStyle,在消费的时候做聚合。 |
||
| ...collapseClassNames, | ||
| header: clsx(collapseClassNames?.header, classNames?.header), | ||
| body: clsx(collapseClassNames?.body, classNames?.body), | ||
| title: clsx(collapseClassNames?.title, classNames?.title), | ||
| icon: clsx(collapseClassNames?.icon, classNames?.icon), | ||
| }; | ||
|
|
||
| const mergeStyles: Partial<Record<SemanticName, React.CSSProperties>> = { | ||
| ...collapseStyles, | ||
| header: { | ||
| ...collapseStyles?.header, | ||
| ...styles?.header, | ||
| }, | ||
| body: { | ||
| ...collapseStyles?.body, | ||
| ...styles?.body, | ||
| }, | ||
| title: { | ||
| ...collapseStyles?.title, | ||
| ...styles?.title, | ||
| }, | ||
| icon: { | ||
| ...collapseStyles?.icon, | ||
| ...styles?.icon, | ||
| }, | ||
| }; | ||
|
|
||
| return ( | ||
| <CollapsePanel | ||
| {...restProps} | ||
| classNames={collapseClassNames} | ||
| styles={styles} | ||
| classNames={mergeClassNames} | ||
| styles={mergeStyles} | ||
| prefixCls={prefixCls} | ||
| key={key} | ||
| panelKey={key} | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renaming
stylestocollapseStylesis a good step to avoid naming collisions. However, this fix for panel-specific styles and classNames appears to be incomplete because it only applies to panels defined via theitemsprop.The
getNewChildfunction (which handlesPanelcomponents passed aschildren, starting on line 88) has not been updated. It still passes theCollapsecomponent'sstylesandclassNamesto eachCollapsePanel, ignoring the props on thePanelitself.To ensure consistent behavior, I recommend applying a similar fix to the
getNewChildfunction. This would involve:classNamesandstylesfromchild.props.childClassNames || collapseClassNamesandchildStyles || collapseStylesto the cloned element.This will make the fix comprehensive, even though
getNewChildis deprecated.