fix: typeof openKeys can be React.Key#347
Open
xyuanbuilds wants to merge 2 commits intoreact-component:masterfrom
Open
fix: typeof openKeys can be React.Key#347xyuanbuilds wants to merge 2 commits intoreact-component:masterfrom
xyuanbuilds wants to merge 2 commits intoreact-component:masterfrom
Conversation
when get keys in onOpenChange to set openKeys, type mismatch. maybe use React.Key is better.
Codecov Report
@@ Coverage Diff @@
## master #347 +/- ##
=======================================
Coverage 95.49% 95.49%
=======================================
Files 11 11
Lines 888 888
Branches 265 265
=======================================
Hits 848 848
Misses 40 40
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when get keys in onOpenChange to set openKeys, type mismatch. maybe use React.Key is better.